From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com
Cc: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Subject: [PATCH v7 04/12] platform/x86/intel/pmt: mutex clean up
Date: Wed, 9 Jul 2025 14:44:50 -0400 [thread overview]
Message-ID: <20250709184458.298283-5-michael.j.ruhl@intel.com> (raw)
In-Reply-To: <20250709184458.298283-1-michael.j.ruhl@intel.com>
The header file for mutex usage and mutex_destroy() cleanup code is
absent from the crashlog.c module.
Add the header file and mutex_destroy().
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
drivers/platform/x86/intel/pmt/crashlog.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
index d40c8e212733..6e32fc1f8f1d 100644
--- a/drivers/platform/x86/intel/pmt/crashlog.c
+++ b/drivers/platform/x86/intel/pmt/crashlog.c
@@ -12,6 +12,7 @@
#include <linux/intel_vsec.h>
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/mutex.h>
#include <linux/pci.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
@@ -262,8 +263,12 @@ static void pmt_crashlog_remove(struct auxiliary_device *auxdev)
struct pmt_crashlog_priv *priv = auxiliary_get_drvdata(auxdev);
int i;
- for (i = 0; i < priv->num_entries; i++)
- intel_pmt_dev_destroy(&priv->entry[i].entry, &pmt_crashlog_ns);
+ for (i = 0; i < priv->num_entries; i++) {
+ struct crashlog_entry *crashlog = &priv->entry[i];
+
+ intel_pmt_dev_destroy(&crashlog->entry, &pmt_crashlog_ns);
+ mutex_destroy(&crashlog->control_mutex);
+ }
}
static int pmt_crashlog_probe(struct auxiliary_device *auxdev,
--
2.50.0
next prev parent reply other threads:[~2025-07-09 18:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 18:44 [PATCH v7 00/12] Crashlog Type1 Version2 support Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 01/12] platform/x86/intel/pmt: fix a crashlog NULL pointer access Michael J. Ruhl
2025-07-11 17:24 ` David Box
2025-07-09 18:44 ` [PATCH v7 02/12] drm/xe: Correct BMG VSEC header sizing Michael J. Ruhl
2025-07-11 17:59 ` David Box
2025-07-12 22:36 ` Ruhl, Michael J
2025-07-09 18:44 ` [PATCH v7 03/12] platform/x86/intel/pmt: white space cleanup Michael J. Ruhl
2025-07-09 18:44 ` Michael J. Ruhl [this message]
2025-07-09 18:44 ` [PATCH v7 05/12] platform/x86/intel/pmt: use guard(mutex) Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 06/12] platform/x86/intel/pmt: re-order trigger logic Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 07/12] platform/x86/intel/pmt: correct types Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 08/12] platform/x86/intel/pmt: decouple sysfs and namespace Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 09/12] platform/x86/intel/pmt: add register access helpers Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 10/12] platform/x86/intel/pmt: refactor base parameter Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 11/12] platform/x86/intel/pmt: use a version struct Michael J. Ruhl
2025-07-09 18:44 ` [PATCH v7 12/12] platform/x86/intel/pmt: support BMG crashlog Michael J. Ruhl
2025-07-09 18:52 ` ✓ CI.KUnit: success for Crashlog Type1 Version2 support (rev7) Patchwork
2025-07-09 19:43 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-09 22:30 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709184458.298283-5-michael.j.ruhl@intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@gmail.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox