Re: [PATCH v3 3/3] drm/i915/edp: eDP Data Overrride

[kernel test robot <lkp@intel.com>]

Hi Suraj,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on linus/master v6.16 next-20250731]
[cannot apply to drm-intel/for-linux-next-fixes drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-vbt-Add-eDP-Data-rate-overrride-field-in-VBT/20250731-131756
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20250731051646.3009255-4-suraj.kandpal%40intel.com
patch subject: [PATCH v3 3/3] drm/i915/edp: eDP Data Overrride
config: arm64-randconfig-001-20250731 (https://download.01.org/0day-ci/archive/20250731/202507311557.c6BFj3kd-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/202507311557.c6BFj3kd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507311557.c6BFj3kd-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_edp_set_data_override_rates':
>> drivers/gpu/drm/i915/display/intel_dp.c:4280:43: error: dereferencing pointer to incomplete type 'const struct intel_bios_encoder_data'
     if (!encoder->devdata || encoder->devdata->display->vbt.version < 263)
                                              ^~
   In file included from include/asm-generic/bitops/hweight.h:6,
                    from arch/arm64/include/asm/bitops.h:23,
                    from include/linux/bitops.h:67,
                    from arch/arm64/include/asm/cache.h:40,
                    from include/vdso/cache.h:5,
                    from include/linux/cache.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/resource_ext.h:11,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from drivers/gpu/drm/i915/display/intel_dp.c:29:
>> drivers/gpu/drm/i915/display/intel_dp.c:4287:16: error: 'devdata' undeclared (first use in this function); did you mean '_edata'?
     if (hweight32(devdata->child.edp_data_rate_override) >= 11)
                   ^~~~~~~
   include/asm-generic/bitops/const_hweight.h:28:44: note: in definition of macro 'hweight32'
    #define hweight32(w) (__builtin_constant_p(w) ? __const_hweight32(w) : __arch_hweight32(w))
                                               ^
   drivers/gpu/drm/i915/display/intel_dp.c:4287:16: note: each undeclared identifier is reported only once for each function it appears in
     if (hweight32(devdata->child.edp_data_rate_override) >= 11)
                   ^~~~~~~
   include/asm-generic/bitops/const_hweight.h:28:44: note: in definition of macro 'hweight32'
    #define hweight32(w) (__builtin_constant_p(w) ? __const_hweight32(w) : __arch_hweight32(w))
                                               ^


vim +4280 drivers/gpu/drm/i915/display/intel_dp.c

  4272	
  4273	static void
  4274	intel_edp_set_data_override_rates(struct intel_dp *intel_dp)
  4275	{
  4276		struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
  4277		int *sink_rates = intel_dp->sink_rates;
  4278		int i, j = 0;
  4279	
> 4280		if (!encoder->devdata || encoder->devdata->display->vbt.version < 263)
  4281			return;
  4282	
  4283		/*
  4284		 * This means the VBT ends up asking us to override every possible rate
  4285		 * indicating the VBT is broken so skip this
  4286		 */
> 4287		if (hweight32(devdata->child.edp_data_rate_override) >= 11)
  4288			return;
  4289	
  4290		for (i = 0; i < intel_dp->num_sink_rates; i++) {
  4291			if (intel_bios_encoder_supports_edp_rate(encoder->devdata,
  4292								 intel_dp->sink_rates[i]))
  4293				continue;
  4294	
  4295			sink_rates[j++] = intel_dp->sink_rates[i];
  4296		}
  4297		intel_dp->num_sink_rates = j;
  4298	}
  4299	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki