intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915/vrr: Drop redundant HAS_VRR checks
@ 2025-08-25 13:57 Ankit Nautiyal
  2025-08-25 15:08 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ankit Nautiyal @ 2025-08-25 13:57 UTC (permalink / raw)
  To: intel-gfx
  Cc: intel-xe, jani.nikula, mitulkumar.ajitkumar.golani,
	Ankit Nautiyal

We fill crtc_state->vrr.flipline only when HAS_VRR() returns true.
This makes HAS_VRR() check redundant in places where we are already
checking for intel_vrr_possible(), which returns true only if vrr.flipline
is set.

Drop such HAS_VRR() checks to simplify the logic.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 3eed37f271b0..b9061cbb67d5 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -652,9 +652,6 @@ void intel_vrr_transcoder_enable(const struct intel_crtc_state *crtc_state)
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
 
-	if (!HAS_VRR(display))
-		return;
-
 	if (!intel_vrr_possible(crtc_state))
 		return;
 
@@ -678,9 +675,6 @@ void intel_vrr_transcoder_disable(const struct intel_crtc_state *crtc_state)
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
 
-	if (!HAS_VRR(display))
-		return;
-
 	if (!intel_vrr_possible(crtc_state))
 		return;
 
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-08-26  4:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-25 13:57 [PATCH] drm/i915/vrr: Drop redundant HAS_VRR checks Ankit Nautiyal
2025-08-25 15:08 ` ✓ CI.KUnit: success for " Patchwork
2025-08-25 15:46 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-25 20:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-08-26  4:44 ` [PATCH] " Golani, Mitulkumar Ajitkumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).