From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v5 4/4] drm/xe: Don't change LRC ring head on job resubmission
Date: Wed, 3 Sep 2025 19:10:08 -0700 [thread overview]
Message-ID: <20250904021008.1827802-5-matthew.brost@intel.com> (raw)
In-Reply-To: <20250904021008.1827802-1-matthew.brost@intel.com>
Now that we save the job's head during submission, it's no longer
necessary to adjust the LRC ring head during resubmission. Instead, a
software-based adjustment of the tail will overwrite the old jobs in
place. For some odd reason, adjusting the LRC ring head didn't work on
parallel queues, which was causing issues in our CI.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 69ed3c159d10..f485767ff580 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -2008,11 +2008,14 @@ static void guc_exec_queue_start(struct xe_exec_queue *q)
struct xe_gpu_scheduler *sched = &q->guc->sched;
if (!exec_queue_killed_or_banned_or_wedged(q)) {
+ struct xe_sched_job *job = xe_sched_first_pending_job(sched);
int i;
trace_xe_exec_queue_resubmit(q);
- for (i = 0; i < q->width; ++i)
- xe_lrc_set_ring_head(q->lrc[i], q->lrc[i]->ring.tail);
+ if (job) {
+ for (i = 0; i < q->width; ++i)
+ q->lrc[i]->ring.tail = job->ptrs[i].head;
+ }
xe_sched_resubmit_jobs(sched);
}
--
2.34.1
next prev parent reply other threads:[~2025-09-04 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 2:10 [PATCH v5 0/4] Core Xe changes preparing for VF migration Matthew Brost
2025-09-04 2:10 ` [PATCH v5 1/4] drm/xe: Save off position in ring in which a job was programmed Matthew Brost
2025-09-04 2:10 ` [PATCH v5 2/4] drm/xe/guc: Track pending-enable source in submission state Matthew Brost
2025-09-04 2:10 ` [PATCH v5 3/4] drm/xe: Track LR jobs in DRM scheduler pending list Matthew Brost
2025-09-04 2:10 ` Matthew Brost [this message]
2025-09-04 2:18 ` ✓ CI.KUnit: success for Core Xe changes preparing for VF migration (rev3) Patchwork
2025-09-04 2:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-04 11:26 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904021008.1827802-5-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox