Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 08/13] drm/i915: Use increase_wm_latency() for the 16Gb DIMM w/a
Date: Fri,  5 Sep 2025 17:58:27 +0300	[thread overview]
Message-ID: <20250905145832.12097-9-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250905145832.12097-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Bump the latency for all watermark levels in the
16Gb+ DIMM w/a. The spec does ask us to do it only for level
0, but it seems more sane to bump all the levels. If the actual
memory access is slower then the wakeup (WM1+) should also
potentially happen earlier.

This also avoids the theoretical case that WM0 would get bumped
higher than WM1+. Not that it is likely to happen because the WM0
latency is always significantly lower than the WM1 latency.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 9eebb908beb8..98a397772678 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -3256,7 +3256,7 @@ adjust_wm_latency(struct intel_display *display)
 	 * to avoid any underrun.
 	 */
 	if (need_16gb_dimm_wa(display))
-		wm[0] += 1;
+		increase_wm_latency(display, 1);
 }
 
 static void mtl_read_wm_latency(struct intel_display *display)
-- 
2.49.1


  parent reply	other threads:[~2025-09-05 14:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 14:58 [PATCH 00/13] drm/1915: skl+ watermark/latency stuff Ville Syrjala
2025-09-05 14:58 ` [PATCH 01/13] drm/i915/dram: Also apply the 16Gb DIMM w/a for larger DRAM chips Ville Syrjala
2025-09-16  8:15   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 02/13] drm/i915: Apply the 16Gb DIMM w/a only for the platforms that need it Ville Syrjala
2025-09-16  8:25   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 03/13] drm/i915: Tweak the read latency fixup code Ville Syrjala
2025-09-16  8:28   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 04/13] drm/i915: Don't pass the latency array to {skl, mtl}_read_wm_latency() Ville Syrjala
2025-09-16  8:35   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 05/13] drm/i915: Move adjust_wm_latency() out from {mtl, skl}_read_wm_latency() Ville Syrjala
2025-09-16  8:36   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 06/13] drm/i915: Extract multiply_wm_latency() from skl_read_wm_latency() Ville Syrjala
2025-09-16  8:41   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 07/13] drm/i915: Extract increase_wm_latency() Ville Syrjala
2025-09-16  8:44   ` Luca Coelho
2025-09-05 14:58 ` Ville Syrjala [this message]
2025-09-16  8:46   ` [PATCH 08/13] drm/i915: Use increase_wm_latency() for the 16Gb DIMM w/a Luca Coelho
2025-09-05 14:58 ` [PATCH 09/13] drm/i915: Extract sanitize_wm_latency() Ville Syrjala
2025-09-16  8:49   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 10/13] drm/i915: Flatten sanitize_wm_latency() a bit Ville Syrjala
2025-09-16  8:58   ` Luca Coelho
2025-09-18 13:31   ` [PATCH v2 " Ville Syrjala
2025-09-05 14:58 ` [PATCH 11/13] drm/i915: Make wm latencies monotonic Ville Syrjala
2025-09-16 10:29   ` Luca Coelho
2025-09-18 13:29     ` Ville Syrjälä
2025-09-05 14:58 ` [PATCH 12/13] drm/i915: Print both the original and adjusted wm latencies Ville Syrjala
2025-09-16  9:25   ` Luca Coelho
2025-09-05 14:58 ` [PATCH 13/13] drm/i915: Make sure wm block/lines are non-decreasing Ville Syrjala
2025-09-16 11:15   ` Luca Coelho
2025-09-05 15:25 ` ✗ CI.checkpatch: warning for drm/1915: skl+ watermark/latency stuff (rev2) Patchwork
2025-09-05 15:26 ` ✓ CI.KUnit: success " Patchwork
2025-09-05 16:02 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-06  1:26 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250905145832.12097-9-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox