From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BCACAC5BB for ; Mon, 29 Sep 2025 02:55:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08A1A10E204; Mon, 29 Sep 2025 02:55:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="I6sVo3Mu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD19F10E204 for ; Mon, 29 Sep 2025 02:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759114549; x=1790650549; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=Tq2WSCvsZo9tVTKTX9UwpZwquLN995Vomkl8o2G4ZGU=; b=I6sVo3MuZvqr1NXVgM2Rz0iM4evZHbhqqLk8Nal1wW4bFw1prXLiK3eR ShfmBZWRdeGjm60k1U23pjLDZ+f0h2h4JGYJGBN2ZqqOytzVEG060fvbj kNdgc0dhLZ82Pcs19X8pWR/UEY0iQu+A5V05qlL/4I3Bk3pLg9b19AItU Rk0FfYDB22FwLpttYCmAp5Yzko2Nsqf3psQunCeYDfVnLwxHCuohD4LFy eei37VKoxFf89skXDvtffRWnYEuZDEw19ehrX6ynED9Glx9R0IjoB0VLU npJgKAuWaGufkmJxRlF1OXUkNuwZHDjjFTYCZHWv9QZzYmT6DIW2ExVYj Q==; X-CSE-ConnectionGUID: 0FSXnhPAT+KTDKnlz3efXQ== X-CSE-MsgGUID: gAWNfwzYSKWt1Ks9W0o7vA== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="61398517" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="61398517" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2025 19:55:49 -0700 X-CSE-ConnectionGUID: 4PvBijyqRxqk8LYjSK6zUQ== X-CSE-MsgGUID: a5u4LdgiT8+5Dtn2vcJpiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,300,1751266800"; d="scan'208";a="182529247" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2025 19:55:47 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Subject: [PATCH v3 01/36] drm/xe: Add NULL checks to scratch LRC allocation Date: Sun, 28 Sep 2025 19:55:07 -0700 Message-Id: <20250929025542.1486303-2-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250929025542.1486303-1-matthew.brost@intel.com> References: <20250929025542.1486303-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" kmalloc can fail, the returned value must have a NULL check. Fixes: 168b5867318b ("drm/xe/vf: Refresh utilization buffer during migration recovery") Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_lrc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 47e9df775072..e1bc102a6cae 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1303,8 +1303,11 @@ static int setup_wa_bb(struct xe_lrc *lrc, struct xe_hw_engine *hwe) u32 *buf = NULL; int ret; - if (lrc->bo->vmap.is_iomem) + if (lrc->bo->vmap.is_iomem) { buf = kmalloc(LRC_WA_BB_SIZE, GFP_KERNEL); + if (!buf) + return -ENOMEM; + } ret = xe_lrc_setup_wa_bb_with_scratch(lrc, hwe, buf); @@ -1347,8 +1350,11 @@ setup_indirect_ctx(struct xe_lrc *lrc, struct xe_hw_engine *hwe) if (xe_gt_WARN_ON(lrc->gt, !state.funcs)) return 0; - if (lrc->bo->vmap.is_iomem) + if (lrc->bo->vmap.is_iomem) { state.buffer = kmalloc(state.max_size, GFP_KERNEL); + if (!state.buffer) + return -ENOMEM; + } ret = setup_bo(&state); if (ret) { -- 2.34.1