Re: [PATCH 1/2] drm/xe/vf: Rename sriov_update_device_info

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on nie [2025-wrz-28 19:48:10 +0200]:
> This is a VF only function and its name should reflect that to
> avoid any confusion. Move the VF check to the caller side.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 09f8a66c9728..0421042597a2 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -688,16 +688,15 @@ static int wait_for_lmem_ready(struct xe_device *xe)
>  }
>  ALLOW_ERROR_INJECTION(wait_for_lmem_ready, ERRNO); /* See xe_pci_probe() */
>  
> -static void sriov_update_device_info(struct xe_device *xe)
> +static void vf_update_device_info(struct xe_device *xe)
>  {
> +	xe_assert(xe, IS_SRIOV_VF(xe));
>  	/* disable features that are not available/applicable to VFs */
> -	if (IS_SRIOV_VF(xe)) {
> -		xe->info.probe_display = 0;
> -		xe->info.has_heci_cscfi = 0;
> -		xe->info.has_heci_gscfi = 0;
> -		xe->info.skip_guc_pc = 1;
> -		xe->info.skip_pcode = 1;
> -	}
> +	xe->info.probe_display = 0;
> +	xe->info.has_heci_cscfi = 0;
> +	xe->info.has_heci_gscfi = 0;
> +	xe->info.skip_guc_pc = 1;
> +	xe->info.skip_pcode = 1;
>  }
>  
>  static int xe_device_vram_alloc(struct xe_device *xe)
> @@ -738,7 +737,8 @@ int xe_device_probe_early(struct xe_device *xe)
>  
>  	xe_sriov_probe_early(xe);
>  
> -	sriov_update_device_info(xe);
> +	if (IS_SRIOV_VF(xe))
> +		vf_update_device_info(xe);
>  
>  	err = xe_pcode_probe_early(xe);
>  	if (err || xe_survivability_mode_is_requested(xe)) {

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.47.1
> 

--