Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Varun Gupta <varun.gupta@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>
Subject: Re: [v6,4/4] drm/xe: Don't change LRC ring head on job resubmission
Date: Mon,  6 Oct 2025 08:39:03 +0530	[thread overview]
Message-ID: <20251006030903.2844511-1-varun.gupta@intel.com> (raw)
In-Reply-To: <20250904024749.1849710-5-matthew.brost@intel.com>

>v6:
> - Also set LRC tail to head so queue is idle coming out of reset
>
>Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Varun Gupta <varun.gupta@intel.com>

>---
> drivers/gpu/drm/xe/xe_guc_submit.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
>index 69ed3c159d10..3fb394f65c3e 100644
>--- a/drivers/gpu/drm/xe/xe_guc_submit.c
>+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
>@@ -2008,11 +2008,17 @@ static void guc_exec_queue_start(struct xe_exec_queue *q)
> 	struct xe_gpu_scheduler *sched = &q->guc->sched;
> 
> 	if (!exec_queue_killed_or_banned_or_wedged(q)) {
>+		struct xe_sched_job *job = xe_sched_first_pending_job(sched);
> 		int i;
> 
> 		trace_xe_exec_queue_resubmit(q);
>-		for (i = 0; i < q->width; ++i)
>-			xe_lrc_set_ring_head(q->lrc[i], q->lrc[i]->ring.tail);
>+		if (job) {
>+			for (i = 0; i < q->width; ++i) {
>+				q->lrc[i]->ring.tail = job->ptrs[i].head;
>+				xe_lrc_set_ring_tail(q->lrc[i],
>+						     xe_lrc_ring_head(q->lrc[i]));
>+			}
>+		}
> 		xe_sched_resubmit_jobs(sched);
> 	}	

  parent reply	other threads:[~2025-10-06  3:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04  2:47 [PATCH v6 0/4] Core Xe changes preparing for VF migration Matthew Brost
2025-09-04  2:47 ` [PATCH v6 1/4] drm/xe: Save off position in ring in which a job was programmed Matthew Brost
2025-09-04  2:47 ` [PATCH v6 2/4] drm/xe/guc: Track pending-enable source in submission state Matthew Brost
2025-09-04  2:47 ` [PATCH v6 3/4] drm/xe: Track LR jobs in DRM scheduler pending list Matthew Brost
2025-09-04  2:47 ` [PATCH v6 4/4] drm/xe: Don't change LRC ring head on job resubmission Matthew Brost
2025-09-24  3:26   ` [v6,4/4] " Varun Gupta
2025-10-06  3:09   ` Varun Gupta [this message]
2025-09-04  2:57 ` ✓ CI.KUnit: success for Core Xe changes preparing for VF migration (rev4) Patchwork
2025-09-04  3:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-04 12:11 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251006030903.2844511-1-varun.gupta@intel.com \
    --to=varun.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox