From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D790CCD187 for ; Mon, 6 Oct 2025 10:44:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40F6110E401; Mon, 6 Oct 2025 10:44:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="anwlzOQH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7088F10E313 for ; Mon, 6 Oct 2025 10:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759747492; x=1791283492; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=Zbt9iY45fKGU3PBNMewF1LTjWNTGlnOrW2JVmHgmJJ8=; b=anwlzOQHoAgXaAjatwN7ho2+wW1fdrk3FmAUiLUuc2YbuKCH3jUfyUwT ULFqpes/55WMepEcAdvg5vxOJvCCOvQkCxzyw0kCmp6hujcOO5WwDVTLe NnxM/eQHo340kQqBR4zmbZvhlQFaz6PoT1GaUew1EoQTY6LO/SqTRO8Wq L+A+chLU4F4DJOtliwIa39hQJS+/UVwntOajjv5Ak+8AcZTfVN0TyXD4c 3VpJXKOH5Uo0aVdH3UqsI8WnzV7KIvzjvjiOWnWfCQJuYonBF07llfX9k 8Z96L3jMb5/CTzvVA6cjjeW1fqZ92BnINoqhblWPPMrnajxoauJ24XgTe w==; X-CSE-ConnectionGUID: llqOVa4cR4acvcuf7/djoA== X-CSE-MsgGUID: 4BG02VWnQOqWvTzT+1a0+w== X-IronPort-AV: E=McAfee;i="6800,10657,11573"; a="84546318" X-IronPort-AV: E=Sophos;i="6.18,319,1751266800"; d="scan'208";a="84546318" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2025 03:44:51 -0700 X-CSE-ConnectionGUID: xWcOKudEQPyNE36TYKZQBQ== X-CSE-MsgGUID: 0gFoysYkT1yCZjNrNoi4yw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,319,1751266800"; d="scan'208";a="203589312" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2025 03:44:50 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Subject: [PATCH v5 06/30] drm/xe: Make LRC W/A scratch buffer usage consistent Date: Mon, 6 Oct 2025 03:44:21 -0700 Message-Id: <20251006104445.2210624-7-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251006104445.2210624-1-matthew.brost@intel.com> References: <20251006104445.2210624-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The LRC W/A currently checks for LRC being iomem in some places, while in others it checks if the scratch buffer is non-NULL. This inconsistency causes issues with the VF post-migration recovery code, which blindly passes in a scratch buffer. This patch standardizes the check by consistently verifying whether the LRC is iomem to determine if the scratch buffer should be used. Signed-off-by: Matthew Brost Reviewed-by: Tomasz Lis Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 9feca10837b0..0c0102eb2bad 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1247,7 +1247,7 @@ static int setup_bo(struct bo_setup_state *state) static void finish_bo(struct bo_setup_state *state) { - if (!state->buffer) + if (!state->lrc->bo->vmap.is_iomem) return; xe_map_memcpy_to(gt_to_xe(state->lrc->gt), &state->lrc->bo->vmap, -- 2.34.1