From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAD91CCD186 for ; Mon, 6 Oct 2025 11:10:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53B1E10E3FD; Mon, 6 Oct 2025 11:10:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XwuxDSZX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD98D10E35E for ; Mon, 6 Oct 2025 11:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759749044; x=1791285044; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=43DjX4XeIiEK7BpiQ6DzR5g7+04qzLTzYTq/hTp2q88=; b=XwuxDSZXmmQskWufHh4+uiIuJdMQnaUPPhxxSVdAYlcECyfKIXCogObu 4DpRmcHJFmdy2Xr+XZMIDSRnHtLn2VE0jNHIBa3S8PLNAH52ZGPOPLukQ Tf5XpQlKTSC85hN18Pf4W8go00+84mwFK3AWN6ISOzV21uQS9lq9mFbiA Ur51l++vG1yYcNAlOK3BvWhtomX7hBIN9ekJa2deaKVeaHTrqn6oYeMtl mC6KpVkt1BcQRzZrGD2GQP1HwGLtso/mot1o2QoJfjQiVixjjL4iYepDA Tu9CsnwK96+BlcTru7bAD644bK/tzzl7JDgRfvupzidxSxWo25sWfGHrj Q==; X-CSE-ConnectionGUID: 0/t+eBNYR9eaGwoL6uQFjw== X-CSE-MsgGUID: eYiLirj6TrauIdY4xC6hOg== X-IronPort-AV: E=McAfee;i="6800,10657,11573"; a="73020382" X-IronPort-AV: E=Sophos;i="6.18,319,1751266800"; d="scan'208";a="73020382" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2025 04:10:43 -0700 X-CSE-ConnectionGUID: VgbSRCcZSgWEryxJ7gcnUQ== X-CSE-MsgGUID: h2ST5nySToWw+i50ryrzSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,319,1751266800"; d="scan'208";a="180655221" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2025 04:10:42 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Subject: [PATCH v6 06/30] drm/xe: Make LRC W/A scratch buffer usage consistent Date: Mon, 6 Oct 2025 04:10:14 -0700 Message-Id: <20251006111038.2234860-7-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251006111038.2234860-1-matthew.brost@intel.com> References: <20251006111038.2234860-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The LRC W/A currently checks for LRC being iomem in some places, while in others it checks if the scratch buffer is non-NULL. This inconsistency causes issues with the VF post-migration recovery code, which blindly passes in a scratch buffer. This patch standardizes the check by consistently verifying whether the LRC is iomem to determine if the scratch buffer should be used. Signed-off-by: Matthew Brost Reviewed-by: Tomasz Lis Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 2c6eae2de1f2..b5083c99dd50 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1247,7 +1247,7 @@ static int setup_bo(struct bo_setup_state *state) static void finish_bo(struct bo_setup_state *state) { - if (!state->buffer) + if (!state->lrc->bo->vmap.is_iomem) return; xe_map_memcpy_to(gt_to_xe(state->lrc->gt), &state->lrc->bo->vmap, -- 2.34.1