Re: [PATCH] drm/xe: Don't force DRM_XE_DEBUG_MEMIRQ for SR-IOV debug

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on czw [2025-paź-02 19:13:08 +0200]:
> For pure SR-IOV debugging there is no need to select already
> separated config for the debugging of the memory based interrupts,
> as the latter is also very noisy on its own. Change config order
> and use a weak reverse dependency instead.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/Kconfig.debug | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig.debug b/drivers/gpu/drm/xe/Kconfig.debug
> index 87902b4bd6d3..01227c77f6d7 100644
> --- a/drivers/gpu/drm/xe/Kconfig.debug
> +++ b/drivers/gpu/drm/xe/Kconfig.debug
> @@ -40,6 +40,17 @@ config DRM_XE_DEBUG_VM
>  
>  	  If in doubt, say "N".
>  
> +config DRM_XE_DEBUG_SRIOV
> +	bool "Enable extra SR-IOV debugging"
> +	default n
> +	imply DRM_XE_DEBUG_MEMIRQ
> +	help
> +	  Enable extra SR-IOV debugging info.
> +
> +	  Recommended for driver developers only.
> +
> +	  If in doubt, say "N".
> +
>  config DRM_XE_DEBUG_MEMIRQ
>  	bool "Enable extra memirq debugging"
>  	default n
> @@ -51,17 +62,6 @@ config DRM_XE_DEBUG_MEMIRQ
>  
>  	  If in doubt, say "N".
>  
> -config DRM_XE_DEBUG_SRIOV
> -	bool "Enable extra SR-IOV debugging"
> -	default n
> -	select DRM_XE_DEBUG_MEMIRQ
> -	help
> -	  Enable extra SR-IOV debugging info.
> -
> -	  Recommended for driver developers only.
> -
> -	  If in doubt, say "N".
> -
>  config DRM_XE_DEBUG_MEM
>  	bool "Enable passing SYS/VRAM addresses to user space"
>  	default n

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> -- 
> 2.47.1
> 

--