From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 656E0CCD18D for ; Tue, 7 Oct 2025 13:05:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76A6210E692; Tue, 7 Oct 2025 13:05:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="aeNEVKvr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0221A10E197 for ; Tue, 7 Oct 2025 13:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759842311; x=1791378311; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=43DjX4XeIiEK7BpiQ6DzR5g7+04qzLTzYTq/hTp2q88=; b=aeNEVKvrB+buHwF/ugytLwCzLWM6y7wcASnTaDlp5ZnJaTxZ3k5VauPc BumUDerGiaBZH4EFWItKxd5Q9oAix7vMmJF2RJXwysNDyBgm2lLMREnPs pqATT4UcNyQ2hXEc0iXDk5Xw/7e4hh4Grdbw4SUVWXYdZcD0120opm3a2 7M2R03MR24ycYdY3r5St4SUsNrqofs6mffzKh/wunqvE0jm2gRTR2xCG2 Qr0nX9jrJenhEJMS8CBuCYH9fjnD76vXt0/GJvIzhJMH77Vu4gQ9/sBbB ANmNiq2DC5jCYZXbCSxwlMa/GpJQzd8j2NVeEOShxT+Cejo6A1fS7BZbK A==; X-CSE-ConnectionGUID: EgD5xDxtTGq8XxbPBolRyA== X-CSE-MsgGUID: 3tLDlnYMTrSy1fAOIlTOcw== X-IronPort-AV: E=McAfee;i="6800,10657,11575"; a="64639826" X-IronPort-AV: E=Sophos;i="6.18,321,1751266800"; d="scan'208";a="64639826" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2025 06:05:11 -0700 X-CSE-ConnectionGUID: t5uk64+KQDSHd8O3Ll4nCw== X-CSE-MsgGUID: JVBsJTuuQ+mgnXH0nzc98A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,321,1751266800"; d="scan'208";a="180576927" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2025 06:05:10 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org Subject: [PATCH v8 07/33] drm/xe: Make LRC W/A scratch buffer usage consistent Date: Tue, 7 Oct 2025 06:04:39 -0700 Message-Id: <20251007130505.2694829-8-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251007130505.2694829-1-matthew.brost@intel.com> References: <20251007130505.2694829-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The LRC W/A currently checks for LRC being iomem in some places, while in others it checks if the scratch buffer is non-NULL. This inconsistency causes issues with the VF post-migration recovery code, which blindly passes in a scratch buffer. This patch standardizes the check by consistently verifying whether the LRC is iomem to determine if the scratch buffer should be used. Signed-off-by: Matthew Brost Reviewed-by: Tomasz Lis Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c index 2c6eae2de1f2..b5083c99dd50 100644 --- a/drivers/gpu/drm/xe/xe_lrc.c +++ b/drivers/gpu/drm/xe/xe_lrc.c @@ -1247,7 +1247,7 @@ static int setup_bo(struct bo_setup_state *state) static void finish_bo(struct bo_setup_state *state) { - if (!state->buffer) + if (!state->lrc->bo->vmap.is_iomem) return; xe_map_memcpy_to(gt_to_xe(state->lrc->gt), &state->lrc->bo->vmap, -- 2.34.1