From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v2 3/3] drm/xe: Change return type of detect_bar2_dgfx() from s64 to u64
Date: Thu, 9 Oct 2025 23:02:30 +0000 [thread overview]
Message-ID: <20251009230239.2830207-8-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20251009230239.2830207-5-shuicheng.lin@intel.com>
The function never returns a negative value, and the return value is
assigned to a u64 variable. Use u64 for better type correctness
and clarity.
v2: add assert to catch theoretical negative or zero stolen size. (Rodrigo)
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c b/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
index 9b00bdc8ef1a..e368b2a36bac 100644
--- a/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
+++ b/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
@@ -81,7 +81,7 @@ static u32 get_wopcm_size(struct xe_device *xe)
return wopcm_size;
}
-static s64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr)
+static u64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr)
{
struct xe_vram_region *tile_vram = xe_device_get_root_tile(xe)->mem.vram;
resource_size_t tile_io_start = xe_vram_region_io_start(tile_vram);
@@ -105,6 +105,8 @@ static s64 detect_bar2_dgfx(struct xe_device *xe, struct xe_ttm_stolen_mgr *mgr)
return 0;
stolen_size = tile_size - mgr->stolen_base;
+
+ xe_assert(xe, stolen_size > wopcm_size);
stolen_size -= wopcm_size;
/* Verify usage fits in the actual resource available */
--
2.49.0
next prev parent reply other threads:[~2025-10-09 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 23:02 [PATCH v2 0/3] Fix copyright Shuicheng Lin
2025-10-09 23:02 ` [PATCH v2 1/3] drm/xe: Fix copyright and function naming in xe_ttm_sys_mgr Shuicheng Lin
2025-10-09 23:02 ` [PATCH v2 2/3] drm/xe: Fix copyright in xe_ttm_stolen_mgr Shuicheng Lin
2025-10-09 23:02 ` Shuicheng Lin [this message]
2025-10-10 19:10 ` [PATCH v2 3/3] drm/xe: Change return type of detect_bar2_dgfx() from s64 to u64 Rodrigo Vivi
2025-10-16 9:57 ` Matthew Auld
2025-10-16 14:54 ` Lin, Shuicheng
2025-10-16 19:33 ` Rodrigo Vivi
2025-10-10 0:24 ` ✓ CI.KUnit: success for Fix copyright (rev2) Patchwork
2025-10-10 1:05 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-10 9:52 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009230239.2830207-8-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox