From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5D45CCD194 for ; Mon, 13 Oct 2025 20:10:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8096310E507; Mon, 13 Oct 2025 20:10:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LIRG5zC5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5C8510E505 for ; Mon, 13 Oct 2025 20:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760386204; x=1791922204; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=T3KRIp6HZ/A2q+CFgj3hyLlN5vI6oZyaAzdBcNVDx3I=; b=LIRG5zC5r7J9wEBROb47mdAmw14JY3tfFMvIeRamBihJlVOxWr/lKSfi SZ65FL0fdB+cMeCaTequpd/WLdo71+EKprQBhChA+RHCatfkFG5lQjqOi 7cIAtaXN8AqmwV6Bdjms5hOLg6f4uUxCBs66f8/fw6yS/R//9sawbsmot zBvGhiBpqQUo5kEYy/IVInRzxGORz3hX3rwCHnDZ/7u0TEDmFpOaDwZ0Q SdIdr7AvswIHUBAl8txKudQpnBgXyGzSFmxcIwX6fBLwnd2QlJHDA2tE8 Me90W7iQV5ZvraiIY8JmWBFpci5ZARADgTHSyQPF6COl3AD4zRzODv4Sj A==; X-CSE-ConnectionGUID: x5gTRdhYShaW85glsA69Mg== X-CSE-MsgGUID: 0rPi9HibRL63UMkOYQh3EA== X-IronPort-AV: E=McAfee;i="6800,10657,11581"; a="72800559" X-IronPort-AV: E=Sophos;i="6.19,226,1754982000"; d="scan'208";a="72800559" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2025 13:10:04 -0700 X-CSE-ConnectionGUID: nepC01C2TWCGoSbZUHXIWQ== X-CSE-MsgGUID: t9vU5ZAwSDWWQi76mI4Big== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,226,1754982000"; d="scan'208";a="185707625" Received: from mdroper-desk1.fm.intel.com ([10.1.39.133]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2025 13:10:03 -0700 From: Matt Roper To: intel-xe@lists.freedesktop.org Cc: matthew.d.roper@intel.com, Gustavo Sousa Subject: [PATCH v5 20/23] drm/xe: Don't check BIOS-disabled FlatCCS if primary GT is disabled Date: Mon, 13 Oct 2025 13:10:03 -0700 Message-ID: <20251013200944.2499947-45-matthew.d.roper@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013200944.2499947-25-matthew.d.roper@intel.com> References: <20251013200944.2499947-25-matthew.d.roper@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" If the primary is GT is disabled via configfs, we can't read the GT registers that would tell us whether the BIOS has disabled FlatCCS on a platform that would otherwise have it; we'll just proceed as if the FlatCCS is still enabled. This is similar to the situation seen by SRIOV VFs and doesn't cause any functional problems since the hardware will simply drop writes to the CCS region and reads will always come back as 0 (indicating uncompressed data). We'll simply miss out on the chance to avoid some unnecessary overhead during BO creation and migration. Signed-off-by: Matt Roper Reviewed-by: Gustavo Sousa --- drivers/gpu/drm/xe/xe_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index e2aa79a78938..5f6a412b571c 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -782,6 +782,8 @@ static int probe_has_flat_ccs(struct xe_device *xe) return 0; gt = xe_root_mmio_gt(xe); + if (!gt) + return 0; fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); if (!fw_ref) -- 2.51.0