From: Vivek Kasireddy <vivek.kasireddy@intel.com>
To: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Cc: "Vivek Kasireddy" <vivek.kasireddy@intel.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Christian Koenig" <christian.koenig@amd.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>
Subject: [RFC 2/8] dma-buf: Add a helper to match interconnects between exporter/importer
Date: Tue, 14 Oct 2025 00:08:52 -0700 [thread overview]
Message-ID: <20251014071243.811884-3-vivek.kasireddy@intel.com> (raw)
In-Reply-To: <20251014071243.811884-1-vivek.kasireddy@intel.com>
If the importer provides an op for supports_interconnects(), the
exporter starts the matching (or negotiation) process (during
attach) by invoking the supports_interconnects() which would then
call this helper to identify the first common interconnect
supported by both exporter and importer.
Note that whether an interconnect is supported between an
exporter/importer is ultimately determined by the exporter via
the match op it is expected to provide.
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Simona Vetter <simona.vetter@ffwll.ch>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
drivers/dma-buf/dma-buf.c | 45 +++++++++++++++++++++++++++-
include/linux/dma-buf-interconnect.h | 6 ++++
include/linux/dma-buf.h | 9 ++++++
3 files changed, 59 insertions(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 162642bd53e8..ed48540d1c1d 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -965,8 +965,11 @@ dma_buf_dynamic_attach(struct dma_buf *dmabuf, struct device *dev,
attach->dev = dev;
attach->dmabuf = dmabuf;
- if (importer_ops)
+ if (importer_ops) {
attach->peer2peer = importer_ops->allow_peer2peer;
+ if (importer_ops->supports_interconnects)
+ attach->allow_ic = true;
+ }
attach->importer_ops = importer_ops;
attach->importer_priv = importer_priv;
@@ -1680,6 +1683,46 @@ void dma_buf_unmap_interconnect(struct dma_buf_attachment *attach,
}
EXPORT_SYMBOL_NS_GPL(dma_buf_unmap_interconnect, "DMA_BUF");
+bool dma_buf_match_interconnects(struct dma_buf_attachment *attach,
+ const struct dma_buf_interconnect_match *exp,
+ unsigned int exp_ics,
+ const struct dma_buf_interconnect_match *imp,
+ unsigned int imp_ics)
+{
+ const struct dma_buf_interconnect *exp_ic, *imp_ic;
+ const struct dma_buf_interconnect_ops *ic_ops;
+ struct dma_buf *dmabuf = attach->dmabuf;
+ unsigned int i, j;
+
+ if (!exp || !imp)
+ return false;
+
+ if (!attach->allow_ic)
+ return false;
+
+ ic_ops = dmabuf->ops->interconnect_ops;
+ if (!ic_ops || !ic_ops->match_interconnect)
+ return false;
+
+ for (i = 0; i < exp_ics; i++) {
+ for (j = 0; j < imp_ics; j++) {
+ exp_ic = exp[i].interconnect;
+ imp_ic = imp[j].interconnect;
+
+ if (exp_ic->type == imp_ic->type) {
+ if (ic_ops->match_interconnect(exp_ic, imp_ic)) {
+ attach->interconnect.type = exp_ic->type;
+ return true;
+ }
+ }
+ }
+ }
+
+ attach->allow_ic = false;
+ return false;
+}
+EXPORT_SYMBOL_NS_GPL(dma_buf_match_interconnects, "DMA_BUF");
+
#ifdef CONFIG_DEBUG_FS
static int dma_buf_debug_show(struct seq_file *s, void *unused)
{
diff --git a/include/linux/dma-buf-interconnect.h b/include/linux/dma-buf-interconnect.h
index 17504dea9691..a72f65ed4806 100644
--- a/include/linux/dma-buf-interconnect.h
+++ b/include/linux/dma-buf-interconnect.h
@@ -20,10 +20,16 @@ struct dma_buf_interconnect {
enum dma_buf_interconnect_type type;
};
+struct dma_buf_interconnect_match {
+ const struct dma_buf_interconnect *interconnect;
+};
+
struct dma_buf_interconnect_ops {
int (*map_interconnect)(struct dma_buf_attachment *attach,
struct dma_buf_ranges *ranges);
void (*unmap_interconnect)(struct dma_buf_attachment *attach,
struct dma_buf_ranges *ranges);
+ bool (*match_interconnect)(const struct dma_buf_interconnect *exp_ic,
+ const struct dma_buf_interconnect *imp_ic);
};
#endif
diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index db91c67c00d6..3e6124387f3c 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -479,6 +479,10 @@ struct dma_buf_attach_ops {
* point to the new location of the DMA-buf.
*/
void (*move_notify)(struct dma_buf_attachment *attach);
+
+ bool (*supports_interconnects)(struct dma_buf_attachment *attach,
+ const struct dma_buf_interconnect_match *,
+ unsigned int num_ics);
};
/**
@@ -599,6 +603,11 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *, struct sg_table *,
struct dma_buf_ranges *dma_buf_map_interconnect(struct dma_buf_attachment *);
void dma_buf_unmap_interconnect(struct dma_buf_attachment *,
struct dma_buf_ranges *);
+bool dma_buf_match_interconnects(struct dma_buf_attachment *attach,
+ const struct dma_buf_interconnect_match *,
+ unsigned int exp_ics,
+ const struct dma_buf_interconnect_match *,
+ unsigned int imp_ics);
void dma_buf_move_notify(struct dma_buf *dma_buf);
int dma_buf_begin_cpu_access(struct dma_buf *dma_buf,
--
2.50.1
next prev parent reply other threads:[~2025-10-14 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 7:08 [RFC 0/8] dma-buf: Add support for mapping dmabufs via interconnects Vivek Kasireddy
2025-10-14 7:08 ` [RFC 1/8] dma-buf: Add support for map/unmap APIs for interconnects Vivek Kasireddy
2025-10-20 9:34 ` Thomas Hellström
2025-10-21 5:45 ` Kasireddy, Vivek
2025-10-28 13:58 ` Christian König
2025-10-28 14:05 ` Jason Gunthorpe
2025-10-28 14:14 ` Christian König
2025-10-28 14:44 ` Jason Gunthorpe
2025-10-14 7:08 ` Vivek Kasireddy [this message]
2025-10-17 15:58 ` [RFC 2/8] dma-buf: Add a helper to match interconnects between exporter/importer Kasireddy, Vivek
2025-10-14 7:08 ` [RFC 3/8] dma-buf: Add support for IOV interconnect Vivek Kasireddy
2025-10-14 7:08 ` [RFC 4/8] vfio/pci/dmabuf: " Vivek Kasireddy
2025-10-14 7:08 ` [RFC 5/8] drm/xe/dma_buf: " Vivek Kasireddy
2025-10-14 7:08 ` [RFC 6/8] drm/xe/pf: Add a helper function to get a VF's backing object in LMEM Vivek Kasireddy
2025-10-14 7:08 ` [RFC 7/8] drm/xe/bo: Create new dma_addr array for dmabuf BOs associated with VFs Vivek Kasireddy
2025-10-14 7:08 ` [RFC 8/8] drm/xe/pt: Add an additional check for dmabuf BOs while doing bind Vivek Kasireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014071243.811884-3-vivek.kasireddy@intel.com \
--to=vivek.kasireddy@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox