Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dri-devel@lists.freedesktop.org,
	"Alexander Usyskin" <alexander.usyskin@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Subject: Re: [PATCH] mei: intel_lb_mei_interface.h: mark struct member with kernel-doc
Date: Thu, 16 Oct 2025 10:21:10 +0200	[thread overview]
Message-ID: <20251016082110.GA256560@pevik> (raw)
In-Reply-To: <20251016035942.1148176-1-rdunlap@infradead.org>

Hi,

...
> Use correct kernel-doc notation to prevent 3 kernel-doc warnings.
> @push_payload is a struct member here, not a function, so use '@'
> and ':' in its description.

>  struct intel_lb_component_ops {
>  	/**
> -	 * push_payload - Sends a payload to the authentication firmware
> +	 * @push_payload: Sends a payload to the authentication firmware

Obviously correct.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

>  	 * @dev: Device struct corresponding to the mei device
>  	 * @type: Payload type (see &enum intel_lb_type)
>  	 * @flags: Payload flags bitmap (e.g. %INTEL_LB_FLAGS_IS_PERSISTENT)

  parent reply	other threads:[~2025-10-16  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  3:59 [PATCH] mei: intel_lb_mei_interface.h: mark struct member with kernel-doc Randy Dunlap
2025-10-16  6:01 ` ✗ CI.checkpatch: warning for " Patchwork
2025-10-16  6:02 ` ✓ CI.KUnit: success " Patchwork
2025-10-16  6:44 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-16  8:21 ` Petr Vorel [this message]
2025-10-16 10:08 ` [PATCH] " Gote, Nitin R
2025-10-16 19:03   ` Randy Dunlap
2025-10-17  0:22 ` ✓ Xe.CI.Full: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251016082110.GA256560@pevik \
    --to=pvorel@suse.cz \
    --cc=airlied@gmail.com \
    --cc=alexander.usyskin@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=rdunlap@infradead.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox