Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	Daniel Stone <daniels@collabora.com>
Subject: [PATCH 4/5] drm/i915/dumb: Reject dumb buffer that exceed max fb dimensions
Date: Tue, 21 Oct 2025 22:44:54 +0300	[thread overview]
Message-ID: <20251021194455.24297-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251021194455.24297-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reject dumb buffers that exceed the declared maximum framebuffer
size. Such a buffer would anyway get rejected later, assuming
it got fully wrapped into a framebuffer.

Cc: Daniel Stone <daniels@collabora.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_plane.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_plane.c b/drivers/gpu/drm/i915/display/intel_plane.c
index f12f8300a7c4..3325d1bc9666 100644
--- a/drivers/gpu/drm/i915/display/intel_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_plane.c
@@ -1709,9 +1709,16 @@ int intel_plane_atomic_check(struct intel_atomic_state *state)
 int intel_plane_dumb_create(struct intel_display *display,
 			    struct drm_mode_create_dumb *args)
 {
+	const struct drm_mode_config *mode_config = &display->drm->mode_config;
 	int cpp = DIV_ROUND_UP(args->bpp, 8);
 	u32 format;
 
+	if (args->width > mode_config->max_width)
+		return -EINVAL;
+
+	if (args->height > mode_config->max_height)
+		return -EINVAL;
+
 	switch (cpp) {
 	case 1:
 		format = DRM_FORMAT_C8;
-- 
2.49.1


  parent reply	other threads:[~2025-10-21 19:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 19:44 [PATCH 0/5] drm/uapi: Intoduce DRM_MODE_DUMB_CURSOR Ville Syrjala
2025-10-21 19:44 ` [PATCH 1/5] drm/uapi: Validate DRM_IOCTL_MODE_CREATE_DUMB flags Ville Syrjala
2025-10-21 19:44 ` [PATCH 2/5] drm/uapi: Introduce the DRM_MODE_DUMB_CURSOR flag Ville Syrjala
2025-10-21 19:44 ` [PATCH 3/5] drm/i915/dumb: Move the display dumb buffer stuff into the display code Ville Syrjala
2025-10-21 19:44 ` Ville Syrjala [this message]
2025-10-21 19:44 ` [PATCH 5/5] drm/i915/dumb: Handle DRM_MODE_DUMB_CURSOR Ville Syrjala
2025-10-21 19:51 ` ✗ CI.checkpatch: warning for drm/uapi: Intoduce DRM_MODE_DUMB_CURSOR Patchwork
2025-10-21 19:52 ` ✓ CI.KUnit: success " Patchwork
2025-10-21 20:07 ` ✗ CI.checksparse: warning " Patchwork
2025-10-21 20:31 ` ✓ Xe.CI.BAT: success " Patchwork
2025-10-21 23:07 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251021194455.24297-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox