From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 446B8CCD1BC for ; Wed, 22 Oct 2025 07:33:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00FC010E6F5; Wed, 22 Oct 2025 07:33:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="jW7ABZGK"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C79010E6EA for ; Wed, 22 Oct 2025 07:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=263vrCNeTRdF52xr0d6yMDxIer3ZTpCX/1troP02Hg4=; b=jW7ABZGKj0LGUpR8vhjS7Rgzod igPSzGreAw9x1LcdUVpaMzlSVk8D5yD1V/m0A3/5Doqug/1naeFK7coco9yxKjhFg18M+ub/J6EmF 7nepiCdQPkD9WPpCyG/ok7FjI9vU61mXL29efNf5pO8VxNts4zUrA+/h12DzEsLD16pzYV/WGOfqf js728UTwI2vxx+QsMBXnxgrIrbFc/y77hyqh58nxIA6yo2H3EHGvk22qH8G8Cfj7s3g17GhQkV+rc O6lLf83qfMzMQdgsEL9uTH+G7M2U5hqiCqKfZkFD/APyqTTfnRb3vXsevV0n7SuHV/gf4c/TQZk94 YzpO1l/A==; Received: from [90.242.12.242] (helo=localhost) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1vBTL1-00Ct1L-92 for ; Wed, 22 Oct 2025 09:32:51 +0200 From: Tvrtko Ursulin To: intel-xe@lists.freedesktop.org Subject: [CI 11/14] drm/xe: Do not use stolen memory for DPT on IGFX and AuxCCS Date: Wed, 22 Oct 2025 08:32:36 +0100 Message-ID: <20251022073241.71401-12-tvrtko.ursulin@igalia.com> X-Mailer: git-send-email 2.48.0 In-Reply-To: <20251022073241.71401-1-tvrtko.ursulin@igalia.com> References: <20251022073241.71401-1-tvrtko.ursulin@igalia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" With DPT in stolen memory there are occasional pipe crc IGT failures in tests such as kms_flip_tiling. Allocate a normal system memory object instead. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/xe/display/xe_fb_pin.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c index af691eee398a..8217abc3a20d 100644 --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c @@ -122,6 +122,20 @@ static void ggtt_flush_writes(struct xe_ggtt *ggtt) } } +static bool try_dpt_stolen(const struct intel_framebuffer *fb, struct xe_bo *bo) +{ + /* + * XXX: DPT in stolen memory on IGFX platforms (at least Alderlake) + * suffers from occasional pipe crc IGT failures in tests such as + * kms_flip_tiling. + */ + if (intel_fb_is_ccs_modifier(fb->base.modifier) && + !xe_bo_is_vram(bo) && !xe_bo_is_stolen(bo)) + return false; + + return true; +} + static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb, const struct i915_gtt_view *view, struct i915_vma *vma, @@ -131,7 +145,7 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb, struct xe_tile *tile0 = xe_device_get_root_tile(xe); struct xe_ggtt *ggtt = tile0->mem.ggtt; struct drm_gem_object *obj = intel_fb_bo(&fb->base); - struct xe_bo *bo = gem_to_xe_bo(obj), *dpt; + struct xe_bo *bo = gem_to_xe_bo(obj), *dpt = ERR_PTR(-EINVAL); u32 dpt_size, size = bo->ttm.base.size; if (view->type == I915_GTT_VIEW_NORMAL) @@ -152,7 +166,7 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb, XE_BO_FLAG_GGTT | XE_BO_FLAG_PAGETABLE, alignment, false); - else + else if (try_dpt_stolen(fb, bo)) dpt = xe_bo_create_pin_map_at_novm(xe, tile0, dpt_size, ~0ull, ttm_bo_type_kernel, -- 2.48.0