Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com
Subject: [PATCH v2 0/2] Fix serialization on burst of unbinds - v2
Date: Fri, 24 Oct 2025 08:23:21 -0700	[thread overview]
Message-ID: <20251024152323.1281242-1-matthew.brost@intel.com> (raw)

Attempting to resolve part of [1]; this solution differs than v1 [2] by
changing last fence semantics detailed in the patches.

Overview of issue in [1]:

When a burst of unbind jobs is issued, a dependency chain can form
between the TLB invalidation of a previous unbind job and the current
one. This leads to undesirable serialization, causing current jobs to
wait unnecessarily for prior TLB invalidations, execute on the GPU when
not needed, and significantly slow down the unbind burst—resulting in up
to a 4× slowdown.
 
Matt

[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6047
[2] https://patchwork.freedesktop.org/series/156144/

Matthew Brost (2):
  drm/xe: Add last fence attachment to TLB invalidation job queues
  drm/xe: Decouple bind queue last fence from TLB invalidations

 drivers/gpu/drm/xe/xe_exec_queue.c       | 100 +++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_exec_queue.h       |  18 ++++
 drivers/gpu/drm/xe/xe_exec_queue_types.h |   5 ++
 drivers/gpu/drm/xe/xe_pt.c               |  64 +++++----------
 drivers/gpu/drm/xe/xe_sync.c             |  62 ++++++++++++--
 drivers/gpu/drm/xe/xe_vm.c               |  60 ++++++++------
 6 files changed, 232 insertions(+), 77 deletions(-)

-- 
2.34.1


             reply	other threads:[~2025-10-24 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 15:23 Matthew Brost [this message]
2025-10-24 15:23 ` [PATCH v2 1/2] drm/xe: Add last fence attachment to TLB invalidation job queues Matthew Brost
2025-10-24 15:23 ` [PATCH v2 2/2] drm/xe: Decouple bind queue last fence from TLB invalidations Matthew Brost
2025-10-24 15:53 ` ✗ CI.checkpatch: warning for Fix serialization on burst of unbinds - v2 Patchwork
2025-10-24 15:54 ` ✓ CI.KUnit: success " Patchwork
2025-10-24 16:40 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-25  5:03 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024152323.1281242-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox