From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com
Subject: [PATCH v4 0/5] Fix serialization on burst of unbinds - v2
Date: Mon, 27 Oct 2025 11:27:32 -0700 [thread overview]
Message-ID: <20251027182737.2358096-1-matthew.brost@intel.com> (raw)
Attempting to resolve part of [1]; this solution differs than v1 [2] by
changing last fence semantics detailed in the patches.
Overview of issue in [1]:
When a burst of unbind jobs is issued, a dependency chain can form
between the TLB invalidation of a previous unbind job and the current
one. This leads to undesirable serialization, causing current jobs to
wait unnecessarily for prior TLB invalidations, execute on the GPU when
not needed, and significantly slow down the unbind burst—resulting in up
to a 4× to 8× slowdown depending on platform.
Matt
[1] https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6047
[2] https://patchwork.freedesktop.org/series/156144/
Matthew Brost (5):
drm/xe: Add last fence attachment to TLB invalidation job queues
drm/xe: Decouple bind queue last fence from TLB invalidations
drm/xe: Do not wait on TLB invalidations in page fault binds
drm/xe: Don't allow in fences on zero batch exec or zero binds
drm/xe: Remove last fence dependecy check from binds
drivers/gpu/drm/xe/xe_exec_queue.c | 108 ++++++++++++++++++++---
drivers/gpu/drm/xe/xe_exec_queue.h | 20 ++++-
drivers/gpu/drm/xe/xe_exec_queue_types.h | 5 ++
drivers/gpu/drm/xe/xe_migrate.c | 14 +++
drivers/gpu/drm/xe/xe_migrate.h | 8 ++
drivers/gpu/drm/xe/xe_pt.c | 80 ++++++-----------
drivers/gpu/drm/xe/xe_sync.c | 74 +++++++++-------
drivers/gpu/drm/xe/xe_tlb_inval_job.c | 31 +++++--
drivers/gpu/drm/xe/xe_tlb_inval_job.h | 5 +-
drivers/gpu/drm/xe/xe_vm.c | 93 +++++++++++--------
drivers/gpu/drm/xe/xe_vm_types.h | 6 +-
11 files changed, 290 insertions(+), 154 deletions(-)
--
2.34.1
next reply other threads:[~2025-10-27 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 18:27 Matthew Brost [this message]
2025-10-27 18:27 ` [PATCH v4 1/5] drm/xe: Add last fence attachment to TLB invalidation job queues Matthew Brost
2025-10-29 16:05 ` Thomas Hellström
2025-10-29 17:48 ` Summers, Stuart
2025-10-29 20:29 ` Matthew Brost
2025-10-29 22:17 ` Summers, Stuart
2025-10-27 18:27 ` [PATCH v4 2/5] drm/xe: Decouple bind queue last fence from TLB invalidations Matthew Brost
2025-10-27 18:27 ` [PATCH v4 3/5] drm/xe: Do not wait on TLB invalidations in page fault binds Matthew Brost
2025-10-27 18:27 ` [PATCH v4 4/5] drm/xe: Don't allow in fences on zero batch exec or zero binds Matthew Brost
2025-10-27 18:27 ` [PATCH v4 5/5] drm/xe: Remove last fence dependecy check from binds Matthew Brost
2025-10-27 18:33 ` ✗ CI.checkpatch: warning for Fix serialization on burst of unbinds - v2 Patchwork
2025-10-27 18:34 ` ✓ CI.KUnit: success " Patchwork
2025-10-27 19:13 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-28 0:12 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027182737.2358096-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox