From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH 2/3] drm/xe/pf: Use migration-friendly doorbells auto-provisioning
Date: Wed, 5 Nov 2025 19:32:51 +0100 [thread overview]
Message-ID: <20251105183253.863-3-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20251105183253.863-1-michal.wajdeczko@intel.com>
Instead of trying very hard to find the largest fair number of GuC
doorbell IDs that could be allocated for VFs on the current GT, pick
some smaller rounded down to power-of-two value that is more likely
to be provisioned in the same manner by the other PF instance:
num VFs | num doorbells
--------+--------------
63..32 | 4
31..16 | 8
15..8 | 16
7..4 | 32
3..2 | 64
1 | 128 (regular PF)
1 | 240 (admin only PF)
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
index 14feda215d5b..701889e5dded 100644
--- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
+++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
@@ -1249,6 +1249,17 @@ int xe_gt_sriov_pf_config_bulk_set_dbs(struct xe_gt *gt, unsigned int vfid,
"GuC doorbell IDs", no_unit, n, err);
}
+static u32 pf_profile_fair_dbs(struct xe_gt *gt, unsigned int num_vfs)
+{
+ bool admin_only_pf = xe_sriov_pf_admin_only(gt_to_xe(gt));
+
+ /* XXX: preliminary */
+ if (admin_only_pf && num_vfs == 1)
+ return GUC_NUM_DOORBELLS - SZ_16;
+
+ return rounddown_pow_of_two(GUC_NUM_DOORBELLS / (num_vfs + 1));
+}
+
static u32 pf_estimate_fair_dbs(struct xe_gt *gt, unsigned int num_vfs)
{
struct xe_guc_db_mgr *dbm = >->uc.guc.dbm;
@@ -1281,6 +1292,7 @@ static u32 pf_estimate_fair_dbs(struct xe_gt *gt, unsigned int num_vfs)
int xe_gt_sriov_pf_config_set_fair_dbs(struct xe_gt *gt, unsigned int vfid,
unsigned int num_vfs)
{
+ u32 profile = pf_profile_fair_dbs(gt, num_vfs);
u32 fair;
xe_gt_assert(gt, vfid);
@@ -1293,6 +1305,11 @@ int xe_gt_sriov_pf_config_set_fair_dbs(struct xe_gt *gt, unsigned int vfid,
if (!fair)
return -ENOSPC;
+ fair = min(fair, profile);
+ if (fair < profile)
+ xe_gt_sriov_info(gt, "Using non-profile provisioning (%s %u vs %u)\n",
+ "GuC doorbell IDs", fair, profile);
+
return xe_gt_sriov_pf_config_bulk_set_dbs(gt, vfid, num_vfs, fair);
}
--
2.47.1
next prev parent reply other threads:[~2025-11-05 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 18:32 [PATCH 0/3] PF: migration-friendly auto-provisioning Michal Wajdeczko
2025-11-05 18:32 ` [PATCH 1/3] drm/xe/pf: Use migration-friendly context IDs auto-provisioning Michal Wajdeczko
2025-11-06 14:24 ` Piotr Piórkowski
2025-11-06 16:55 ` Michal Wajdeczko
2025-11-05 18:32 ` Michal Wajdeczko [this message]
2025-11-06 14:39 ` [PATCH 2/3] drm/xe/pf: Use migration-friendly doorbells auto-provisioning Piotr Piórkowski
2025-11-05 18:32 ` [PATCH 3/3] drm/xe/tests: Add KUnit tests for PF fair provisioning Michal Wajdeczko
2025-11-06 16:09 ` Piotr Piórkowski
2025-11-06 16:59 ` [PATCH v2 " Michal Wajdeczko
2025-11-05 21:28 ` ✗ CI.checkpatch: warning for PF: migration-friendly auto-provisioning Patchwork
2025-11-05 21:30 ` ✓ CI.KUnit: success " Patchwork
2025-11-05 22:46 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-11-06 9:50 ` ✗ Xe.CI.Full: " Patchwork
2025-11-06 17:13 ` ✗ CI.checkpatch: warning for PF: migration-friendly auto-provisioning (rev2) Patchwork
2025-11-06 17:15 ` ✓ CI.KUnit: success " Patchwork
2025-11-06 17:53 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-07 14:52 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105183253.863-3-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox