[PATCH 1/2] drm/xe: Coalesce pagefault logging

[Lucas De Marchi <lucas.demarchi@intel.com>]

The page fault is only ever printed on when the fault handling fails.
Use a single dbg with the fault response status and its details.

Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_pagefault.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
index fe3e401450129..68bcc25f27890 100644
--- a/drivers/gpu/drm/xe/xe_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_pagefault.c
@@ -222,15 +222,17 @@ static bool xe_pagefault_queue_pop(struct xe_pagefault_queue *pf_queue,
 	return found_fault;
 }
 
-static void xe_pagefault_print(struct xe_pagefault *pf)
+static void xe_pagefault_print(struct xe_pagefault *pf, int err)
 {
-	xe_gt_dbg(pf->gt, "\n\tASID: %d\n"
+	xe_gt_dbg(pf->gt, "\nFault response: Unsuccessful %pe\n"
+		  "\tASID: %d\n"
 		  "\tFaulted Address: 0x%08x%08x\n"
 		  "\tFaultType: %d\n"
 		  "\tAccessType: %d\n"
 		  "\tFaultLevel: %d\n"
 		  "\tEngineClass: %d %s\n"
 		  "\tEngineInstance: %d\n",
+		  ERR_PTR(err),
 		  pf->consumer.asid,
 		  upper_32_bits(pf->consumer.page_addr),
 		  lower_32_bits(pf->consumer.page_addr),
@@ -259,11 +261,8 @@ static void xe_pagefault_queue_work(struct work_struct *w)
 			continue;
 
 		err = xe_pagefault_service(&pf);
-		if (err) {
-			xe_pagefault_print(&pf);
-			xe_gt_dbg(pf.gt, "Fault response: Unsuccessful %pe\n",
-				  ERR_PTR(err));
-		}
+		if (err)
+			xe_pagefault_print(&pf, err);
 
 		pf.producer.ops->ack_fault(&pf, err);
 

-- 
2.51.2