Re: [PATCH v1] drm/xe: Move VRAM MM debugfs creation to tile level

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Summers, Stuart <stuart.summers@intel.com> wrote on czw [2025-lis-06 00:16:33 +0100]:
> On Wed, 2025-11-05 at 17:59 +0100, Piórkowski, Piotr wrote:
> > > > > From: Piotr Piórkowski <piotr.piorkowski@intel.com>
> > > > > 
> > > > > Previously, VRAM TTM resource manager debugfs entries (vram0_mm
> > > > > / > > > vram1_mm)
> > > > > were created globally in the XE debugfs root directory. But > >
> > > > > > technically,
> > > > > each tile has an associated VRAM TTM manager, which it can own.
> > > > > Let's create VRAM memory manager debugfs entries directly under
> > > > > > > each > tile's
> > > > > debugfs directory for better alignment with the per-tile memory
> > > > > > > > layout.
> > > > > 
> > > > > Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> 
> I agree this makes more sense.
> 
> I do see the debugfs IGT seems to be hard coded though which is causing
> BAT to fail.
> 
> With that fixed:
> Reviewed-by: Stuart Summers <stuart.summers@intel.com>

Hey, I already have the appropriate patch for IGT ready, but I will send it next Wednesday
(due to the long weekend in Poland).

Thanks for review!
Piotr

> 
> > > > > ---
> > > > >  drivers/gpu/drm/xe/xe_debugfs.c      | 12 ------------
> > > > >  drivers/gpu/drm/xe/xe_tile_debugfs.c |  9 +++++++++
> > > > >  2 files changed, 9 insertions(+), 12 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/xe/xe_debugfs.c > > >
> > > > > b/drivers/gpu/drm/xe/xe_debugfs.c
> > > > > index e91da9589c5f..8ac78e560d28 100644
> > > > > --- a/drivers/gpu/drm/xe/xe_debugfs.c
> > > > > +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> > > > > @@ -375,7 +375,6 @@ void xe_debugfs_register(struct xe_device
> > > > > *xe)
> > > > >         struct ttm_resource_manager *man;
> > > > >         struct xe_tile *tile;
> > > > >         struct xe_gt *gt;
> > > > > -       u32 mem_type;
> > > > >         u8 tile_id;
> > > > >         u8 id;
> > > > >  
> > > > > @@ -403,17 +402,6 @@ void xe_debugfs_register(struct xe_device
> > > > > *xe)
> > > > >         debugfs_create_file("disable_late_binding", 0600, root,
> > > > > xe,
> > > > >                             &disable_late_binding_fops);
> > > > >  
> > > > > -       for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; >
> > > > > > > ++mem_type) {
> > > > > -               man = ttm_manager_type(bdev, mem_type);
> > > > > -
> > > > > -               if (man) {
> > > > > -                       char name[16];
> > > > > -
> > > > > -                       snprintf(name, sizeof(name),
> > > > > "vram%d_mm", > > > mem_type - XE_PL_VRAM0);
> > > > > -
> > > > >                        ttm_resource_manager_create_debugfs(man,
> > > > > > > > root, name);
> > > > > -               }
> > > > > -       }
> > > > > -
> > > > >         man = ttm_manager_type(bdev, XE_PL_TT);
> > > > >         ttm_resource_manager_create_debugfs(man, root,
> > > > > "gtt_mm");
> > > > >  
> > > > > diff --git a/drivers/gpu/drm/xe/xe_tile_debugfs.c > > >
> > > > > b/drivers/gpu/drm/xe/xe_tile_debugfs.c
> > > > > index fff242a5ae56..b4a1929535da 100644
> > > > > --- a/drivers/gpu/drm/xe/xe_tile_debugfs.c
> > > > > +++ b/drivers/gpu/drm/xe/xe_tile_debugfs.c
> > > > > @@ -110,6 +110,13 @@ static const struct drm_info_list > > >
> > > > > vf_safe_debugfs_list[] = {
> > > > >         { "sa_info", .show = xe_tile_debugfs_show_with_rpm,
> > > > > .data = > > > sa_info },
> > > > >  };
> > > > >  
> > > > > +static void tile_debugfs_create_vram_mm(struct xe_tile *tile)
> > > > > +{
> > > > > +       if (tile->mem.vram)
> > > > > +               ttm_resource_manager_create_debugfs(&tile-
> > > > > >mem.vram> > ->> ttm.manager, tile->debugfs,
> > > > > +                                                   "vram_mm");
> > > > > +}
> > > > > +
> > > > >  /**
> > > > >   * xe_tile_debugfs_register - Register tile's debugfs
> > > > > attributes
> > > > >   * @tile: the &xe_tile to register
> > > > > @@ -139,4 +146,6 @@ void xe_tile_debugfs_register(struct
> > > > > xe_tile > > > *tile)
> > > > >         drm_debugfs_create_files(vf_safe_debugfs_list,
> > > > >                                 
> > > > > ARRAY_SIZE(vf_safe_debugfs_list),
> > > > >                                  tile->debugfs, minor);
> > > > > +
> > > > > +       tile_debugfs_create_vram_mm(tile);
> > > > >  }
> 

--