From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57265CCFA1A for ; Tue, 11 Nov 2025 09:42:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18FF610E527; Tue, 11 Nov 2025 09:42:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="A0UgbUDq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DD6210E527; Tue, 11 Nov 2025 09:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762854177; x=1794390177; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=q/7iOCgiejYKAxKzQ13+TfIH0OZoZ7YWwHEuYn/3lyo=; b=A0UgbUDq+6BsL1X19o73Z+N2fiCqkZ2PheCTtoqxO8Q+sM1aadTL+NvU mkAxHK3gPIC2SLFH2AeV2W6y+qckmC8LQ1mPJI6L2cOlevsaNzRogn/nY T4B6b73TxjPMTXqa3mkv0eeL4XB1EMvMC6JP7preNsDrMzjZ4N4kcNZ/x fXjq4wyEUjLhZOJF1K1a9HTaBmoj/dP7IbSj4R68RBxkwWs0vaZF93sXR OplvXeHvlGByWuPzdz+wdmGdH2aCGM8e8WCWyHoQNb0Ab1yqc3xtABbJy FxOCQfwVPugbABcWPlbV+VGdBTW7FzEuh+XaxiMeJilzbIdKB1CwOodJx Q==; X-CSE-ConnectionGUID: aQPo6wEDQwu+IhKaVAOuKQ== X-CSE-MsgGUID: o/yf20rhSB2Iie08GTjvBA== X-IronPort-AV: E=McAfee;i="6800,10657,11609"; a="68773762" X-IronPort-AV: E=Sophos;i="6.19,296,1754982000"; d="scan'208";a="68773762" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2025 01:42:57 -0800 X-CSE-ConnectionGUID: t9aM194fRj6qMcw7+XHczQ== X-CSE-MsgGUID: 0bWiNd2sRFqE0cfjTMppWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,296,1754982000"; d="scan'208";a="193175871" Received: from srr4-3-linux-103-aknautiy.iind.intel.com ([10.223.34.160]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2025 01:42:54 -0800 From: Ankit Nautiyal To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com, Ankit Nautiyal , Mitul Golani Subject: [PATCH 1/4] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Date: Tue, 11 Nov 2025 15:00:04 +0530 Message-ID: <20251111093007.3771409-2-ankit.k.nautiyal@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20251111093007.3771409-1-ankit.k.nautiyal@intel.com> References: <20251111093007.3771409-1-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Correct the bit-shift logic to properly readback the 10 bit target_rr from DB3 and DB4. v2: Align the style with readback for vtotal. (Ville) Fixes: 12ea89291603 ("drm/i915/dp: Add Read/Write support for Adaptive Sync SDP") Cc: Mitul Golani Cc: Ankit Nautiyal Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 0ec82fcbcf48..92a553a76b57 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -4997,7 +4997,7 @@ int intel_dp_as_sdp_unpack(struct drm_dp_as_sdp *as_sdp, as_sdp->length = sdp->sdp_header.HB3 & DP_ADAPTIVE_SYNC_SDP_LENGTH; as_sdp->mode = sdp->db[0] & DP_ADAPTIVE_SYNC_SDP_OPERATION_MODE; as_sdp->vtotal = (sdp->db[2] << 8) | sdp->db[1]; - as_sdp->target_rr = (u64)sdp->db[3] | ((u64)sdp->db[4] & 0x3); + as_sdp->target_rr = ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; as_sdp->target_rr_divider = sdp->db[4] & 0x20 ? true : false; return 0; -- 2.45.2