From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 4/6] drm/i915: Use hw.active instead of uapi.active in the initial plane readout
Date: Wed, 19 Nov 2025 20:16:04 +0200 [thread overview]
Message-ID: <20251119181606.17129-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251119181606.17129-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We're interested in the actual hardware state rather than the uapi
state, so grab the crtc active flag from the correct spot.
In practice the two will be identical here becase
.get_initial_plane_config() will reject the initial FB when
joiner is active.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_plane_initial.c | 6 ++++--
drivers/gpu/drm/xe/display/xe_plane_initial.c | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_plane_initial.c b/drivers/gpu/drm/i915/display/intel_plane_initial.c
index a1de1ec564d1..ff1afd3a8f20 100644
--- a/drivers/gpu/drm/i915/display/intel_plane_initial.c
+++ b/drivers/gpu/drm/i915/display/intel_plane_initial.c
@@ -39,7 +39,7 @@ intel_reuse_initial_plane_obj(struct intel_crtc *this,
const struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
- if (!crtc_state->uapi.active)
+ if (!crtc_state->hw.active)
continue;
if (!plane_state->ggtt_vma)
@@ -411,10 +411,12 @@ void intel_initial_plane_config(struct intel_display *display)
struct intel_crtc *crtc;
for_each_intel_crtc(display->drm, crtc) {
+ const struct intel_crtc_state *crtc_state =
+ to_intel_crtc_state(crtc->base.state);
struct intel_initial_plane_config *plane_config =
&plane_configs[crtc->pipe];
- if (!to_intel_crtc_state(crtc->base.state)->uapi.active)
+ if (!crtc_state->hw.active)
continue;
/*
diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 12d25c5290fd..01c105a93bb9 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -58,7 +58,7 @@ intel_reuse_initial_plane_obj(struct intel_crtc *this,
const struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
- if (!crtc_state->uapi.active)
+ if (!crtc_state->hw.active)
continue;
if (!plane_state->ggtt_vma)
@@ -290,10 +290,12 @@ void intel_initial_plane_config(struct intel_display *display)
struct intel_crtc *crtc;
for_each_intel_crtc(display->drm, crtc) {
+ const struct intel_crtc_state *crtc_state =
+ to_intel_crtc_state(crtc->base.state);
struct intel_initial_plane_config *plane_config =
&plane_configs[crtc->pipe];
- if (!to_intel_crtc_state(crtc->base.state)->uapi.active)
+ if (!crtc_state->hw.active)
continue;
/*
--
2.49.1
next prev parent reply other threads:[~2025-11-19 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 18:16 [PATCH 0/6] drm/i915: uapi vs. hw state fixes Ville Syrjala
2025-11-19 18:16 ` [PATCH 1/6] drm/i915: Use the proper (hw.crtc) for the cursor unpin vblank worker Ville Syrjala
2025-11-19 18:16 ` [PATCH 2/6] drm/i915/psr: Use hw.crtc instead of uapi.crtc Ville Syrjala
2025-11-19 18:16 ` [PATCH 3/6] drm/i915/psr: Use hw.rotation instead of uapi.rotation Ville Syrjala
2025-11-19 18:16 ` Ville Syrjala [this message]
2025-11-19 18:16 ` [PATCH 5/6] drm/i915/panic: Get the crtc from the correct place Ville Syrjala
2025-11-19 18:16 ` [PATCH 6/6] drm/i915/panic: Clean up the variables Ville Syrjala
2025-11-19 18:30 ` ✓ CI.KUnit: success for drm/i915: uapi vs. hw state fixes Patchwork
2025-11-19 19:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-19 23:04 ` ✓ Xe.CI.Full: " Patchwork
2025-11-25 19:41 ` [PATCH 0/6] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119181606.17129-5-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox