From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 1/2] drm/gpusvm: Limit the number of retries in drm_gpusvm_get_pages
Date: Fri, 21 Nov 2025 17:25:01 -0800 [thread overview]
Message-ID: <20251122012502.382587-1-matthew.brost@intel.com> (raw)
drm_gpusvm_get_pages should not be allowed to retry forever, cap the
time spent in the function to HMM_RANGE_DEFAULT_TIMEOUT has this is
essentially a wrapper around hmm_range_fault.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/drm_gpusvm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
index 73e550c8ff8c..39c8c50401dd 100644
--- a/drivers/gpu/drm/drm_gpusvm.c
+++ b/drivers/gpu/drm/drm_gpusvm.c
@@ -1288,6 +1288,9 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm,
DMA_BIDIRECTIONAL;
retry:
+ if (time_after(jiffies, timeout))
+ return -EBUSY;
+
hmm_range.notifier_seq = mmu_interval_read_begin(notifier);
if (drm_gpusvm_pages_valid_unlocked(gpusvm, svm_pages))
goto set_seqno;
--
2.34.1
next reply other threads:[~2025-11-22 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 1:25 Matthew Brost [this message]
2025-11-22 1:25 ` [PATCH 2/2] drm/xe: Covert return of -EBUSY to -ENOMEM in VM bind IOCTL Matthew Brost
2025-11-24 6:09 ` Upadhyay, Tejas
2025-11-24 21:42 ` ✓ CI.KUnit: success for series starting with [1/2] drm/gpusvm: Limit the number of retries in drm_gpusvm_get_pages Patchwork
2025-11-24 22:20 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-25 0:45 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-26 3:16 ` [PATCH 1/2] " Ghimiray, Himal Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251122012502.382587-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox