Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Laguna <lukasz.laguna@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, rodrigo.vivi@intel.com,
	lukasz.laguna@intel.com
Subject: [PATCH v10 4/4] drm/xe/pf: Allow upon-any-hang wedged mode only in debug config
Date: Tue, 25 Nov 2025 14:54:22 +0100	[thread overview]
Message-ID: <20251125135422.11244-5-lukasz.laguna@intel.com> (raw)
In-Reply-To: <20251125135422.11244-1-lukasz.laguna@intel.com>

The GuC reset policy is global, so disabling it on PF can affect all
running VFs. To avoid unintended side effects, restrict setting
upon-any-hang (2) wedged mode on the PF to debug builds only.

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index da12924f191c..d7c36b86bc7b 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -1302,7 +1302,8 @@ int xe_device_validate_wedged_mode(struct xe_device *xe, unsigned int mode)
 	if (mode > XE_WEDGED_MODE_UPON_ANY_HANG) {
 		drm_dbg(&xe->drm, "wedged_mode: invalid value (%u)\n", mode);
 		return -EINVAL;
-	} else if (mode == XE_WEDGED_MODE_UPON_ANY_HANG && IS_SRIOV_VF(xe)) {
+	} else if (mode == XE_WEDGED_MODE_UPON_ANY_HANG && (IS_SRIOV_VF(xe) ||
+		   (IS_SRIOV_PF(xe) && !IS_ENABLED(CONFIG_DRM_XE_DEBUG)))) {
 		drm_dbg(&xe->drm, "wedged_mode: (%u) %s mode is not supported for %s\n",
 			mode, xe_wedged_mode_to_string(mode),
 			xe_sriov_mode_to_string(xe_device_sriov_mode(xe)));
-- 
2.40.0


  parent reply	other threads:[~2025-11-25 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 13:54 [PATCH v10 0/4] drm/xe: Improve wedged mode handling Lukasz Laguna
2025-11-25 13:54 ` [PATCH v10 1/4] drm/xe: Validate wedged_mode parameter and define enum for modes Lukasz Laguna
2025-11-25 18:08   ` Rodrigo Vivi
2025-11-26 14:37     ` Laguna, Lukasz
2025-11-25 13:54 ` [PATCH v10 2/4] drm/xe: Don't update wedged mode in case of an error Lukasz Laguna
2025-11-25 18:13   ` Rodrigo Vivi
2025-11-26 14:42     ` Laguna, Lukasz
2025-11-25 13:54 ` [PATCH v10 3/4] drm/xe/vf: Disallow setting wedged mode to upon-any-hang Lukasz Laguna
2025-11-25 13:54 ` Lukasz Laguna [this message]
2025-11-25 21:28 ` ✓ CI.KUnit: success for drm/xe: Improve wedged mode handling (rev10) Patchwork
2025-11-25 22:29 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-26  1:32 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251125135422.11244-5-lukasz.laguna@intel.com \
    --to=lukasz.laguna@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox