From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Matthew Auld" <matthew.auld@intel.com>
Subject: [RFC PATCH] drm/xe/bo: Honor madvise(2) advices
Date: Fri, 28 Nov 2025 11:46:23 +0100 [thread overview]
Message-ID: <20251128104623.32742-1-thomas.hellstrom@linux.intel.com> (raw)
The user can give advices as to how the CPU will access an
address range. Use those advices to determine the number of
bo pages to prefault on a page-fault.
Do this regardless of whether we can find a way to avoid the
fairly slow vm_insert_pfn_prot() to populate buffer
object maps.
Initially, fault up to 512 pages on sequential access and
a single page on random access.
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 6fd6ce6c6586..07d0d954f826 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1821,15 +1821,31 @@ static int xe_bo_fault_migrate(struct xe_bo *bo, struct ttm_operation_ctx *ctx,
return err;
}
+/*
+ * Number of prefaulted pages for the MADV_SEQUENTIAL and
+ * MADV_RANDOM madvise() advices.
+ */
+#define XE_BO_VM_NUM_PREFAULT_SEQ 512
+#define XE_BO_VM_NUM_PREFAULT_RAND 1
+
/* Call into TTM to populate PTEs, and register bo for PTE removal on runtime suspend. */
static vm_fault_t __xe_bo_cpu_fault(struct vm_fault *vmf, struct xe_device *xe, struct xe_bo *bo)
{
+ const struct vm_area_struct *vma = vmf->vma;
+ pgoff_t num_prefault;
vm_fault_t ret;
trace_xe_bo_cpu_fault(bo);
+ if (vma->vm_flags & VM_SEQ_READ)
+ num_prefault = XE_BO_VM_NUM_PREFAULT_SEQ;
+ else if (vma->vm_flags & VM_RAND_READ)
+ num_prefault = XE_BO_VM_NUM_PREFAULT_RAND;
+ else
+ num_prefault = TTM_BO_VM_NUM_PREFAULT;
+
ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
- TTM_BO_VM_NUM_PREFAULT);
+ num_prefault);
/*
* When TTM is actually called to insert PTEs, ensure no blocking conditions
* remain, in which case TTM may drop locks and return VM_FAULT_RETRY.
--
2.51.1
next reply other threads:[~2025-11-28 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 10:46 Thomas Hellström [this message]
2025-11-28 10:53 ` ✓ CI.KUnit: success for drm/xe/bo: Honor madvise(2) advices Patchwork
2025-11-28 12:57 ` [RFC PATCH] " Matthew Auld
2025-11-28 21:01 ` Matthew Brost
2025-11-29 12:51 ` Thomas Hellström
2025-11-29 15:55 ` Matthew Brost
2025-11-29 16:18 ` Thomas Hellström
2025-11-29 12:40 ` Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128104623.32742-1-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox