From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFCAED116F3 for ; Mon, 1 Dec 2025 23:55:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E38D10E4D8; Mon, 1 Dec 2025 23:55:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nATemgV/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10E1610E4E6; Mon, 1 Dec 2025 23:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764633343; x=1796169343; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rDoP3Ma4ImOpne5cneuynZ4V5CxUjs4B5cgP6H3fM7I=; b=nATemgV/pk2KZ89OYeYnNlyC7s5qdfd/CIDzBGZQt/ZBn2vHyq19FlUQ TsVCJWcdyQ1kSn9HsOkEEF7xzUCjn1ar7Ved2gJGHABqg7P9lulZURUUN MVN2/kUv1JpijAZ/d4wgf507YvI9x8Zvv9JtZgBxssGPVa8+Hm97y7nqv PP81b9HtmTEI8OHETLv8z2Z8tUiC/GlPmiWLsDW/JJkQU7Afz/eqHGKNU lyJAJ8Z6mhlQ+rs08Dl7ttd2Uwp7P3lxNMmKFZEXZHLdrWujocXwkCljU 2XDAmGv5mMJC17YyPn+5wuPh/abr+u5xsjgQJvNrRTqurzxyHaFG/enyf g==; X-CSE-ConnectionGUID: bVJDTTPPR42Mkt/pN/XhIA== X-CSE-MsgGUID: +mmorxa7QhmVGesvEPqE3Q== X-IronPort-AV: E=McAfee;i="6800,10657,11630"; a="89235937" X-IronPort-AV: E=Sophos;i="6.20,241,1758610800"; d="scan'208";a="89235937" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 15:55:43 -0800 X-CSE-ConnectionGUID: uNqkMFN6SIqMw+NhDf+q4w== X-CSE-MsgGUID: +x62Tg2+RQulDVhEyVEpKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,241,1758610800"; d="scan'208";a="198410925" Received: from dut4086lnl.fm.intel.com ([10.105.10.149]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 15:55:43 -0800 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, dafna.hirschfeld@intel.com Subject: [PATCH v28 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Mon, 1 Dec 2025 23:55:41 +0000 Message-ID: <20251201235539.236686-7-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201235539.236686-6-jonathan.cavitt@intel.com> References: <20251201235539.236686-6-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index afb06598b6e1..0b625a52a598 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0