From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 3/5] drm/xe/oa: Allow exec_queue's to be specified only for OAG OA unit
Date: Mon, 1 Dec 2025 18:51:13 -0800 [thread overview]
Message-ID: <20251202025115.373546-4-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20251202025115.373546-1-ashutosh.dixit@intel.com>
Exec_queue's are only used for OAR/OAC functionality for OAG unit. Make
this requirement explicit, which avoids complications in the code for
other (non-OAG) OA units.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/xe/xe_oa.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 75db5530cb557..d63c04e2d4922 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -2032,6 +2032,10 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f
return ret;
if (param.exec_queue_id > 0) {
+ /* An exec_queue is only needed for OAR/OAC functionality on OAG */
+ if (XE_IOCTL_DBG(oa->xe, param.oa_unit->type != DRM_XE_OA_UNIT_TYPE_OAG))
+ return -EINVAL;
+
param.exec_q = xe_exec_queue_lookup(xef, param.exec_queue_id);
if (XE_IOCTL_DBG(oa->xe, !param.exec_q))
return -ENOENT;
--
2.48.1
next prev parent reply other threads:[~2025-12-02 2:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 2:51 [PATCH v2 0/5] OA: More OA and register whitelist changes Ashutosh Dixit
2025-12-02 2:51 ` [PATCH 1/5] drm/xe/oa: Use explicit struct initialization for struct xe_oa_regs Ashutosh Dixit
2025-12-02 2:51 ` [PATCH v2 2/5] drm/xe/oa/uapi: Add gt_id to struct drm_xe_oa_unit Ashutosh Dixit
2025-12-02 22:27 ` Umesh Nerlige Ramappa
2025-12-02 23:16 ` Umesh Nerlige Ramappa
2025-12-02 2:51 ` Ashutosh Dixit [this message]
2025-12-02 2:51 ` [PATCH 4/5] drm/xe/rtp: Refactor OAG MMIO trigger register whitelisting Ashutosh Dixit
2025-12-02 2:51 ` [PATCH 5/5] drm/xe/rtp: Whitelist OAM MMIO trigger registers Ashutosh Dixit
2025-12-02 4:03 ` ✗ CI.checkpatch: warning for OA: More OA and register whitelist changes (rev2) Patchwork
2025-12-02 4:05 ` ✓ CI.KUnit: success " Patchwork
2025-12-02 5:06 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-02 7:27 ` ✗ Xe.CI.Full: failure " Patchwork
2025-12-02 21:30 ` Dixit, Ashutosh
2025-12-03 16:19 ` ✗ CI.checkpatch: warning for OA: More OA and register whitelist changes (rev3) Patchwork
2025-12-03 16:21 ` ✓ CI.KUnit: success " Patchwork
2025-12-04 5:01 ` ✗ CI.checkpatch: warning for OA: More OA and register whitelist changes (rev4) Patchwork
2025-12-04 5:03 ` ✓ CI.KUnit: success " Patchwork
2025-12-04 6:04 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-04 6:53 ` ✗ Xe.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-11-26 3:52 [PATCH 0/5] OA: More OA and register whitelist changes Ashutosh Dixit
2025-11-26 3:52 ` [PATCH 3/5] drm/xe/oa: Allow exec_queue's to be specified only for OAG OA unit Ashutosh Dixit
2025-11-26 20:15 ` Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202025115.373546-4-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox