From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C565D12663 for ; Tue, 2 Dec 2025 18:46:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACB7610E6B2; Tue, 2 Dec 2025 18:46:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Xqxf1hGz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 784FD10E6B1; Tue, 2 Dec 2025 18:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764701198; x=1796237198; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rDoP3Ma4ImOpne5cneuynZ4V5CxUjs4B5cgP6H3fM7I=; b=Xqxf1hGz9ry91JuhKj9/gL2NTA+VqLCLQA8A7t60ASV0IigbMQBCqKBg ZqcnEnvGJrTLzUrL6eBBb7j2h/gw/Z0Py93SeYFvTrWQL2lLaWbKq1ZTP rkXWSz8bgyQgUCNNILGmEYTYrKdNiqRxQZplk2ABafkzUbgugQPEqr/Ed SW7DlpaGTK3VhKf384X6yXfWAClwrEtoqboZj0lii0J4gMLPDoj74jTNs bOa6HbHWJaFc87rqyDGYoGucok+l5RMFK1xrIq6FM9gf+9O1wlNs7hFfj Ye2sgPFtWe2MaOL/mQpoBUBXE/mwszwUkv8JUbPvV6D3ZdF6+iKXw6IQ5 g==; X-CSE-ConnectionGUID: 5x8BUFpwTrSvRhgLTy6geg== X-CSE-MsgGUID: +cT+jsTIT4S+bcqzWB/EuA== X-IronPort-AV: E=McAfee;i="6800,10657,11631"; a="89335157" X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="89335157" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 10:46:38 -0800 X-CSE-ConnectionGUID: j1pymbgjRnObRxsvYs+2+g== X-CSE-MsgGUID: SCinR3/ETpSgBvYvBAOiKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,243,1758610800"; d="scan'208";a="194123363" Received: from dut4086lnl.fm.intel.com ([10.105.10.149]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 10:46:37 -0800 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, dafna.hirschfeld@intel.com Subject: [PATCH v29 1/5] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Tue, 2 Dec 2025 18:46:38 +0000 Message-ID: <20251202184636.96142-8-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251202184636.96142-7-jonathan.cavitt@intel.com> References: <20251202184636.96142-7-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index afb06598b6e1..0b625a52a598 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0