From: Arvind Yadav <arvind.yadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.brost@intel.com, himal.prasad.ghimiray@intel.com,
thomas.hellstrom@linux.intel.com, pallavi.mishra@intel.com
Subject: [RFC v3 7/8] drm/xe/madvise: Block imported and exported dma-bufs
Date: Wed, 10 Dec 2025 10:00:51 +0530 [thread overview]
Message-ID: <20251210043112.3267620-8-arvind.yadav@intel.com> (raw)
In-Reply-To: <20251210043112.3267620-1-arvind.yadav@intel.com>
Prevent marking imported or exported dma-bufs as purgeable.
External devices may be accessing these buffers without our
knowledge, making purging unsafe.
Check drm_gem_is_imported() for buffers created by other
drivers and obj->dma_buf for buffers exported to other
drivers. Silently skip these BOs during madvise processing.
This follows drm_gem_shmem's purgeable implementation and
prevents data corruption from purging actively-used shared
buffers.
v3:
- Addresses review feedback from Matt Roper about handling
imported/exported BOs correctly in the purgeable BO
implementation.
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
---
drivers/gpu/drm/xe/xe_vm_madvise.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c
index 9f2d6c1d3062..868be570664d 100644
--- a/drivers/gpu/drm/xe/xe_vm_madvise.c
+++ b/drivers/gpu/drm/xe/xe_vm_madvise.c
@@ -159,6 +159,31 @@ static void madvise_pat_index(struct xe_device *xe, struct xe_vm *vm,
}
}
+/**
+ * xe_bo_is_external_dmabuf() - Check if BO is imported or exported dma-buf
+ * @bo: Buffer object
+ *
+ * Prevent marking imported or exported dma-bufs as purgeable.
+ * External devices may be accessing these buffers without our
+ * knowledge, making purging unsafe.
+ *
+ * Return: true if BO is imported or exported, false otherwise
+ */
+static bool xe_bo_is_external_dmabuf(struct xe_bo *bo)
+{
+ struct drm_gem_object *obj = &bo->ttm.base;
+
+ /* Imported from another driver */
+ if (drm_gem_is_imported(obj))
+ return true;
+
+ /* Exported to another driver */
+ if (obj->dma_buf)
+ return true;
+
+ return false;
+}
+
/**
* xe_bo_all_vmas_dontneed() - Check if all VMAs of a BO are marked DONTNEED
* @bo: Buffer object
@@ -179,6 +204,10 @@ static bool xe_bo_all_vmas_dontneed(struct xe_bo *bo)
dma_resv_assert_held(bo->ttm.base.resv);
+ /* External dma-bufs cannot be purgeable */
+ if (xe_bo_is_external_dmabuf(bo))
+ return false;
+
drm_gem_for_each_gpuvm_bo(vm_bo, obj) {
drm_gpuvm_bo_for_each_va(gpuva, vm_bo) {
struct xe_vma *vma = gpuva_to_vma(gpuva);
--
2.43.0
next prev parent reply other threads:[~2025-12-10 4:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 4:30 [RFC v3 0/8] drm/xe/madvise: Add support for purgeable buffer objects Arvind Yadav
2025-12-10 4:30 ` [RFC v3 1/8] drm/xe/uapi: Add UAPI " Arvind Yadav
2025-12-10 5:33 ` Matthew Brost
2025-12-10 7:16 ` Yadav, Arvind
2026-01-22 13:32 ` Thomas Hellström
2025-12-10 4:30 ` [RFC v3 2/8] drm/xe/bo: Add purgeable bo state tracking and field madv to xe_bo Arvind Yadav
2025-12-10 5:46 ` Matthew Brost
2025-12-10 7:18 ` Yadav, Arvind
2025-12-10 4:30 ` [RFC v3 3/8] drm/xe/madvise: Implement purgeable buffer object support Arvind Yadav
2025-12-10 4:30 ` [RFC v3 4/8] drm/xe/bo: Handle CPU faults on purged buffer objects Arvind Yadav
2025-12-10 4:30 ` [RFC v3 5/8] drm/xe/vm: Prevent binding of " Arvind Yadav
2025-12-10 4:30 ` [RFC v3 6/8] drm/xe/madvise: Implement per-VMA purgeable state tracking Arvind Yadav
2025-12-10 4:30 ` Arvind Yadav [this message]
2025-12-10 4:30 ` [RFC v3 8/8] drm/xe/bo: Add purgeable shrinker state helpers Arvind Yadav
2025-12-11 7:22 ` ✗ CI.checkpatch: warning for drm/xe/madvise: Add support for purgeable buffer objects (rev4) Patchwork
2025-12-11 7:24 ` ✓ CI.KUnit: success " Patchwork
2025-12-11 7:57 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-11 14:56 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210043112.3267620-8-arvind.yadav@intel.com \
--to=arvind.yadav@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=pallavi.mishra@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox