From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: badal.nilawar@intel.com, anoop.c.vijay@intel.com
Subject: [PATCH v4 3/3] drm/xe/soc_remapper: Add system controller config for SoC remapper
Date: Mon, 15 Dec 2025 17:19:08 -0800 [thread overview]
Message-ID: <20251216011904.2771875-8-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20251216011904.2771875-5-umesh.nerlige.ramappa@intel.com>
Define system controller config bits and helpers for SoC remapper.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
v2: (Badal)
- Add kernel doc for function
v3: (Badal)
- Prevent bad access to SoC remapper
---
drivers/gpu/drm/xe/regs/xe_soc_remapper_regs.h | 1 +
drivers/gpu/drm/xe/xe_device_types.h | 5 +++++
drivers/gpu/drm/xe/xe_pci.c | 2 ++
drivers/gpu/drm/xe/xe_pci_types.h | 1 +
drivers/gpu/drm/xe/xe_soc_remapper.c | 12 +++++++++++-
5 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/regs/xe_soc_remapper_regs.h b/drivers/gpu/drm/xe/regs/xe_soc_remapper_regs.h
index 9edf234227a9..be0eb37e73ad 100644
--- a/drivers/gpu/drm/xe/regs/xe_soc_remapper_regs.h
+++ b/drivers/gpu/drm/xe/regs/xe_soc_remapper_regs.h
@@ -9,5 +9,6 @@
#define SG_REMAP_INDEX1 XE_REG(SOC_BASE + 0x08)
#define SG_REMAP_TELEM_MASK REG_GENMASK(31, 24)
+#define SG_REMAP_SYSCTRL_MASK REG_GENMASK(23, 16)
#endif
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index f2ad91815c64..9b78eb88cbb1 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -322,6 +322,8 @@ struct xe_device {
u8 has_range_tlb_inval:1;
/** @info.has_soc_remapper_telem: Has SoC remapper telemetry support */
u8 has_soc_remapper_telem:1;
+ /** @info.has_soc_remapper_sysctrl: Has SoC remapper system controller */
+ u8 has_soc_remapper_sysctrl:1;
/** @info.has_sriov: Supports SR-IOV */
u8 has_sriov:1;
/** @info.has_usm: Device has unified shared memory support */
@@ -569,6 +571,9 @@ struct xe_device {
/** @soc_remapper.set_telem_region: Set telemetry index */
void (*set_telem_region)(struct xe_device *xe, u32 index);
+
+ /** @soc_remapper.set_sysctrl_region: Set system controller index */
+ void (*set_sysctrl_region)(struct xe_device *xe, u32 index);
} soc_remapper;
/**
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index d08375f7bae8..1c97d404ba9d 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -414,6 +414,7 @@ static const struct xe_device_desc cri_desc = {
.has_flat_ccs = false,
.has_mbx_power_limits = true,
.has_mert = true,
+ .has_soc_remapper_sysctrl = true,
.has_soc_remapper_telem = true,
.has_sriov = true,
.max_gt_per_tile = 2,
@@ -683,6 +684,7 @@ static int xe_info_init_early(struct xe_device *xe,
xe->info.has_llc = desc->has_llc;
xe->info.has_mert = desc->has_mert;
xe->info.has_pxp = desc->has_pxp;
+ xe->info.has_soc_remapper_sysctrl = desc->has_soc_remapper_sysctrl;
xe->info.has_soc_remapper_telem = desc->has_soc_remapper_telem;
xe->info.has_sriov = xe_configfs_primary_gt_allowed(to_pci_dev(xe->drm.dev)) &&
desc->has_sriov;
diff --git a/drivers/gpu/drm/xe/xe_pci_types.h b/drivers/gpu/drm/xe/xe_pci_types.h
index 41175fb5dc9d..4303a84310cc 100644
--- a/drivers/gpu/drm/xe/xe_pci_types.h
+++ b/drivers/gpu/drm/xe/xe_pci_types.h
@@ -50,6 +50,7 @@ struct xe_device_desc {
u8 has_mem_copy_instr:1;
u8 has_mert:1;
u8 has_pxp:1;
+ u8 has_soc_remapper_sysctrl:1;
u8 has_soc_remapper_telem:1;
u8 has_sriov:1;
u8 needs_scratch:1;
diff --git a/drivers/gpu/drm/xe/xe_soc_remapper.c b/drivers/gpu/drm/xe/xe_soc_remapper.c
index 1baf5d38e4cd..f894f4899cf3 100644
--- a/drivers/gpu/drm/xe/xe_soc_remapper.c
+++ b/drivers/gpu/drm/xe/xe_soc_remapper.c
@@ -20,6 +20,12 @@ static void xe_soc_remapper_set_telem_region(struct xe_device *xe, u32 index)
REG_FIELD_PREP(SG_REMAP_TELEM_MASK, index));
}
+static void xe_soc_remapper_set_sysctrl_region(struct xe_device *xe, u32 index)
+{
+ xe_soc_remapper_set_region(xe, SG_REMAP_INDEX1, SG_REMAP_SYSCTRL_MASK,
+ REG_FIELD_PREP(SG_REMAP_SYSCTRL_MASK, index));
+}
+
/**
* xe_soc_remapper_init() - Initialize SoC remapper
* @xe: Pointer to xe device.
@@ -30,7 +36,8 @@ static void xe_soc_remapper_set_telem_region(struct xe_device *xe, u32 index)
*/
int xe_soc_remapper_init(struct xe_device *xe)
{
- bool has_soc_remapper = xe->info.has_soc_remapper_telem;
+ bool has_soc_remapper = xe->info.has_soc_remapper_telem ||
+ xe->info.has_soc_remapper_sysctrl;
if (has_soc_remapper)
spin_lock_init(&xe->soc_remapper.lock);
@@ -38,5 +45,8 @@ int xe_soc_remapper_init(struct xe_device *xe)
if (xe->info.has_soc_remapper_telem)
xe->soc_remapper.set_telem_region = xe_soc_remapper_set_telem_region;
+ if (xe->info.has_soc_remapper_sysctrl)
+ xe->soc_remapper.set_sysctrl_region = xe_soc_remapper_set_sysctrl_region;
+
return 0;
}
--
2.43.0
prev parent reply other threads:[~2025-12-16 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 1:19 [PATCH v4 0/3] Add SoC remapper support for system controller Umesh Nerlige Ramappa
2025-12-16 1:19 ` [PATCH v4 1/3] drm/xe/soc_remapper: Initialize SoC remapper during Xe probe Umesh Nerlige Ramappa
2025-12-16 1:19 ` [PATCH v4 2/3] drm/xe/soc_remapper: Use SoC remapper herlper from VSEC code Umesh Nerlige Ramappa
2025-12-16 1:19 ` Umesh Nerlige Ramappa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216011904.2771875-8-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=anoop.c.vijay@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox