Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com,
	apopple@nvidia.com, airlied@gmail.com,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	felix.kuehling@amd.com,
	"Christian König" <christian.koenig@amd.com>,
	dakr@kernel.org, "Mrozek, Michal" <michal.mrozek@intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>
Subject: [PATCH v6 17/24] drm/xe/vm: Add a couple of VM debug printouts
Date: Fri, 19 Dec 2025 12:33:13 +0100	[thread overview]
Message-ID: <20251219113320.183860-18-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20251219113320.183860-1-thomas.hellstrom@linux.intel.com>

Add debug printouts that are valueable for pagemap prefetch,
migration and page collection.

v2:
- Add additional debug prinouts around migration and page collection.
- Require CONFIG_DRM_XE_DEBUG_VM.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com> #v1
---
 drivers/gpu/drm/xe/xe_svm.c | 10 ++++++++++
 drivers/gpu/drm/xe/xe_vm.c  |  7 +++++++
 2 files changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
index c4997ab4e029..43af813276b8 100644
--- a/drivers/gpu/drm/xe/xe_svm.c
+++ b/drivers/gpu/drm/xe/xe_svm.c
@@ -1271,6 +1271,10 @@ static int __xe_svm_handle_pagefault(struct xe_vm *vm, struct xe_vma *vma,
 	if (err) {
 		range_debug(range, "PAGE FAULT - FAIL PAGE COLLECT");
 		goto out;
+	} else if (IS_ENABLED(CONFIG_DRM_XE_DEBUG_VM)) {
+		drm_dbg(&vm->xe->drm, "After page collect data location is %sin \"%s\".\n",
+			xe_svm_range_has_pagemap(range, dpagemap) ? "" : "NOT ",
+			dpagemap ? dpagemap->drm->unique : "System.");
 	}
 
 	xe_svm_range_get_pages_us_stats_incr(gt, range, get_pages_start);
@@ -1566,9 +1570,15 @@ struct drm_pagemap *xe_vma_resolve_pagemap(struct xe_vma *vma, struct xe_tile *t
 int xe_svm_alloc_vram(struct xe_svm_range *range, const struct drm_gpusvm_ctx *ctx,
 		      struct drm_pagemap *dpagemap)
 {
+	struct xe_device *xe = range_to_vm(&range->base)->xe;
+
 	xe_assert(range_to_vm(&range->base)->xe, range->base.pages.flags.migrate_devmem);
 	range_debug(range, "ALLOCATE VRAM");
 
+	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG_VM))
+		drm_dbg(&xe->drm, "Request migration to device memory on \"%s\".\n",
+			dpagemap->drm->unique);
+
 	return drm_pagemap_populate_mm(dpagemap, xe_svm_range_start(range),
 				       xe_svm_range_end(range),
 				       range->base.gpusvm->mm,
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 808b44fb0569..a07d8b53de66 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2931,6 +2931,13 @@ static int prefetch_ranges(struct xe_vm *vm, struct xe_vma_op *op)
 		if (!dpagemap)
 			xe_svm_range_migrate_to_smem(vm, svm_range);
 
+		if (IS_ENABLED(CONFIG_DRM_XE_DEBUG_VM)) {
+			drm_dbg(&vm->xe->drm,
+				"Prefetch pagemap is %s start 0x%016lx end 0x%016lx\n",
+				dpagemap ? dpagemap->drm->unique : "system",
+				xe_svm_range_start(svm_range), xe_svm_range_end(svm_range));
+		}
+
 		if (xe_svm_range_needs_migrate_to_vram(svm_range, vma, dpagemap)) {
 			err = xe_svm_alloc_vram(svm_range, &ctx, dpagemap);
 			if (err) {
-- 
2.51.1


  parent reply	other threads:[~2025-12-19 11:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 11:32 [PATCH v6 00/24] Dynamic drm_pagemaps and Initial multi-device SVM Thomas Hellström
2025-12-19 11:32 ` [PATCH v6 01/24] drm/xe/svm: Fix a debug printout Thomas Hellström
2025-12-19 11:32 ` [PATCH v6 02/24] drm/pagemap: Remove some dead code Thomas Hellström
2025-12-19 11:32 ` [PATCH v6 03/24] drm/pagemap, drm/xe: Ensure that the devmem allocation is idle before use Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 04/24] drm/pagemap, drm/xe: Add refcounting to struct drm_pagemap Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 05/24] drm/pagemap: Add a refcounted drm_pagemap backpointer to struct drm_pagemap_zdd Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 06/24] drm/pagemap, drm/xe: Manage drm_pagemap provider lifetimes Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 07/24] drm/pagemap: Add a drm_pagemap cache and shrinker Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 08/24] drm/xe: Use the " Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 09/24] drm/pagemap: Remove the drm_pagemap_create() interface Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 10/24] drm/pagemap_util: Add a utility to assign an owner to a set of interconnected gpus Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 11/24] drm/xe: Use the drm_pagemap_util helper to get a svm pagemap owner Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 12/24] drm/xe: Pass a drm_pagemap pointer around with the memory advise attributes Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 13/24] drm/xe: Use the vma attibute drm_pagemap to select where to migrate Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 14/24] drm/xe: Simplify madvise_preferred_mem_loc() Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 15/24] drm/xe/uapi: Extend the madvise functionality to support foreign pagemap placement for svm Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 16/24] drm/xe: Support pcie p2p dma as a fast interconnect Thomas Hellström
2025-12-19 11:33 ` Thomas Hellström [this message]
2025-12-19 11:33 ` [PATCH v6 18/24] drm/xe/svm: Document how xe keeps drm_pagemap references Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 19/24] drm/pagemap, drm/xe: Clean up the use of the device-private page owner Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 20/24] drm/gpusvm: Introduce a function to scan the current migration state Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 21/24] drm/xe: Use drm_gpusvm_scan_mm() Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 22/24] drm/pagemap, drm/xe: Support destination migration over interconnect Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 23/24] drm/pagemap: Support source " Thomas Hellström
2025-12-19 11:33 ` [PATCH v6 24/24] drm/xe/svm: Serialize migration to device if racing Thomas Hellström
2025-12-19 13:31 ` [PATCH v6 00/24] Dynamic drm_pagemaps and Initial multi-device SVM Maarten Lankhorst
2025-12-22 18:44 ` ✗ CI.checkpatch: warning for Dynamic drm_pagemaps and Initial multi-device SVM (rev7) Patchwork
2025-12-22 18:45 ` ✓ CI.KUnit: success " Patchwork
2025-12-22 19:21 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-22 20:14 ` ✗ CI.checkpatch: warning for Dynamic drm_pagemaps and Initial multi-device SVM (rev8) Patchwork
2025-12-22 20:16 ` ✓ CI.KUnit: success " Patchwork
2025-12-22 21:15 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-23  2:31 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219113320.183860-18-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=apopple@nvidia.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=matthew.brost@intel.com \
    --cc=michal.mrozek@intel.com \
    --cc=simona.vetter@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox