From: Raag Jadav <raag.jadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, matthew.brost@intel.com,
michal.wajdeczko@intel.com, badal.nilawar@intel.com,
karthik.poosa@intel.com, matthew.d.roper@intel.com,
dev@lankhorst.se, jani.nikula@intel.com,
ville.syrjala@linux.intel.com, uma.shankar@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2] drm/xe/pm: Handle GT resume failure
Date: Sat, 20 Dec 2025 13:06:56 +0530 [thread overview]
Message-ID: <20251220073657.166810-1-raag.jadav@intel.com> (raw)
We've been historically ignoring GT resume failure. Since the function
can return error, handle it properly.
v2: Bring up display before bailing (Matt Roper, Rodrigo)
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_pm.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index 4390ba69610d..559cf5490ac0 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -260,10 +260,19 @@ int xe_pm_resume(struct xe_device *xe)
xe_irq_resume(xe);
- for_each_gt(gt, xe, id)
- xe_gt_resume(gt);
+ for_each_gt(gt, xe, id) {
+ err = xe_gt_resume(gt);
+ if (err)
+ break;
+ }
+ /*
+ * Try to bring up display before bailing from GT resume failure,
+ * so we don't leave the user clueless with a blank screen.
+ */
xe_display_pm_resume(xe);
+ if (err)
+ goto err;
err = xe_bo_restore_late(xe);
if (err)
@@ -656,10 +665,19 @@ int xe_pm_runtime_resume(struct xe_device *xe)
xe_irq_resume(xe);
- for_each_gt(gt, xe, id)
- xe->d3cold.allowed ? xe_gt_resume(gt) : xe_gt_runtime_resume(gt);
+ for_each_gt(gt, xe, id) {
+ err = xe->d3cold.allowed ? xe_gt_resume(gt) : xe_gt_runtime_resume(gt);
+ if (err)
+ break;
+ }
+ /*
+ * Try to bring up display before bailing from GT resume failure,
+ * so we don't leave the user clueless with a blank screen.
+ */
xe_display_pm_runtime_resume(xe);
+ if (err)
+ goto out;
if (xe->d3cold.allowed) {
err = xe_bo_restore_late(xe);
--
2.43.0
next reply other threads:[~2025-12-20 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 7:36 Raag Jadav [this message]
2025-12-21 3:08 ` [PATCH v2] drm/xe/pm: Handle GT resume failure Vivi, Rodrigo
2026-01-08 11:54 ` Raag Jadav
2026-01-08 20:34 ` Rodrigo Vivi
2025-12-22 10:30 ` ✓ CI.KUnit: success for drm/xe/pm: Handle GT resume failure (rev2) Patchwork
2025-12-22 11:05 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-22 11:49 ` ✓ CI.KUnit: " Patchwork
2025-12-22 12:28 ` ✓ Xe.CI.Full: " Patchwork
2026-01-09 2:44 ` [PATCH v2] drm/xe/pm: Handle GT resume failure Nilawar, Badal
2026-01-09 5:58 ` Raag Jadav
2026-01-09 11:07 ` Nilawar, Badal
2026-01-09 13:43 ` Raag Jadav
2026-01-09 14:50 ` Vivi, Rodrigo
2026-01-10 7:35 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251220073657.166810-1-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=karthik.poosa@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox