From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE5D2CD0403 for ; Mon, 5 Jan 2026 20:53:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 107D710E43D; Mon, 5 Jan 2026 20:53:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JtHfb1BG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 429F410E013; Mon, 5 Jan 2026 20:53:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767646405; x=1799182405; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aGmefwmnfdFfAmWz4v9TXCs+rHbmtg9DWTmRlYuIRh8=; b=JtHfb1BGhpvSO7UVXLHFlqY9O3C8KsQ+UsdSL/fAq6yezpcPmAEWryFA h7VVb19kUjGQzqRr7CHPoVHUBHMcfQMPrCqF/JxNWDg6YMVAh9rISpCmd LFsoVKwcjo7bR57e+Be5aodrAePkYo4i/nt6E/myPt/EglvnqYBrSiW0a qWw15/j7WZhPFTcool3Me/OtE8ipMhygMgrn6ukruKHCkXKTmRtSZfAsZ HnlZneQBx+4/4J79Ht5hHigV1nlz24tBjxSsjI7hZ02H8NEJpXCUaEm5R MmkoOrETflkkUW6R/JaNmUVczfXNH/92Fd1KcXuwsDSDU28/8x8BB7gjq Q==; X-CSE-ConnectionGUID: pyuMBPHQTQWRidT7634X8Q== X-CSE-MsgGUID: hJvi0zi3TAmZZNJh/DtYZQ== X-IronPort-AV: E=McAfee;i="6800,10657,11662"; a="68924223" X-IronPort-AV: E=Sophos;i="6.21,204,1763452800"; d="scan'208";a="68924223" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 12:53:25 -0800 X-CSE-ConnectionGUID: zdgAH0+wSaeHs/FN3Dhz+g== X-CSE-MsgGUID: YyOCEZm8RzOepx/Vac3Bnw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,204,1763452800"; d="scan'208";a="233613794" Received: from dut4450lnl.fm.intel.com ([10.105.10.103]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 12:53:25 -0800 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, dafna.hirschfeld@intel.com Subject: [PATCH v32 1/5] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Mon, 5 Jan 2026 20:53:25 +0000 Message-ID: <20260105205323.81875-8-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260105205323.81875-7-jonathan.cavitt@intel.com> References: <20260105205323.81875-7-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index 6bee53d6ffc3..922a4f3344b1 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0