Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Piotr Piórkowski" <piotr.piorkowski@intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	<intel-xe@lists.freedesktop.org>,
	Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation
Date: Wed, 14 Jan 2026 17:15:57 +0100	[thread overview]
Message-ID: <20260114161557.4xormlap6mu457wg@intel.com> (raw)
In-Reply-To: <93f45e1e-0893-48ed-8d41-caf3a7114603@lankhorst.se>

Maarten Lankhorst <dev@lankhorst.se> wrote on śro [2026-sty-14 10:55:02 +0100]:
> Hey,
> 
> Den 2026-01-13 kl. 23:53, skrev Michal Wajdeczko:
> > 
> > 
> > On 1/13/2026 1:18 PM, Maarten Lankhorst wrote:

<snip>

> >> -}
> >> -
> >> -/**
> >> - * xe_ggtt_shift_nodes_locked - Shift GGTT nodes to adjust for a change in usable address range.
> >> + * xe_ggtt_shift_nodes - Shift GGTT nodes to adjust for a change in usable address range.
> > 
> > nit: add () after function name
> Seems to be about 50/50 whether () is used? Both ways are used extensively in xe, often within the same file.
> > 


Based on https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation
we should use ()

Thanks
Piotr

</snip>
-- 

  reply	other threads:[~2026-01-14 16:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 12:18 [PATCH v4 0/5] drm/xe: Privatize struct xe_ggtt Maarten Lankhorst
2026-01-13 12:18 ` [PATCH v4 1/5] drm/xe: Make xe_ggtt_node offset relative to starting offset Maarten Lankhorst
2026-01-13 22:07   ` Michal Wajdeczko
2026-01-14  9:48     ` Maarten Lankhorst
2026-01-13 12:18 ` [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation Maarten Lankhorst
2026-01-13 22:53   ` Michal Wajdeczko
2026-01-14  9:55     ` Maarten Lankhorst
2026-01-14 16:15       ` Piotr Piórkowski [this message]
2026-01-14 17:03         ` Maarten Lankhorst
2026-01-13 12:18 ` [PATCH v4 3/5] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2026-01-13 12:18 ` [PATCH v4 4/5] drm/xe: Make xe_ggtt_node_insert return a node Maarten Lankhorst
2026-01-13 23:12   ` Michal Wajdeczko
2026-01-13 12:18 ` [PATCH v4 5/5] drm/xe: Remove xe_ggtt_node_allocated Maarten Lankhorst
2026-01-13 12:23 ` ✗ CI.checkpatch: warning for drm/xe: Privatize struct xe_ggtt. (rev2) Patchwork
2026-01-13 12:25 ` ✓ CI.KUnit: success " Patchwork
2026-01-13 13:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-13 20:02 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114161557.4xormlap6mu457wg@intel.com \
    --to=piotr.piorkowski@intel.com \
    --cc=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox