From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 514CAD4A615 for ; Fri, 16 Jan 2026 08:55:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C640410E839; Fri, 16 Jan 2026 08:55:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mRaFjH/S"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A6A110E82E; Fri, 16 Jan 2026 08:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768553712; x=1800089712; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RP59RR1HWAvbsj4hT/gEhWhXF9JkI5v28sHskBYWKB4=; b=mRaFjH/S09PlU1BfZt7scSrmerLIAS9Po6EOxh5PLhRQ4C/vJVtQ5uaJ qZ+6kkksTO4Mpoesrg/Z5Tb5Sk9DtgSgaUkis5zZMph6erK8WdXXrSr2g b4KSs8XyUpxRu/t6L1m1LOG8AMbrL8T+Y0Mx1vSTBu1+2dVqKWA3lowtW 55VDSIzeortBu58ye33aFUUQ9u86soc2yODogqCeyvFXoGjGOY3IDL0NI nrRZgIvzFYvMM01rTjS8D2hooqy2gHwJv3/LFVr0AnIawWz9HB3SSLYo8 PNVO5TGlKp6TpGP/Pg9GPuXP+LtmRsHEvhBDUzbxOghCz2k/xuCcmCIWV A==; X-CSE-ConnectionGUID: 8eSyttTwTMCLAOR8lTqc7g== X-CSE-MsgGUID: 2x8mQD0PQx+rPURqupZI7Q== X-IronPort-AV: E=McAfee;i="6800,10657,11672"; a="69918119" X-IronPort-AV: E=Sophos;i="6.21,230,1763452800"; d="scan'208";a="69918119" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2026 00:55:11 -0800 X-CSE-ConnectionGUID: J1tTs30zQpGmT7oTJrwFKA== X-CSE-MsgGUID: pUMZplRbRhGAwknXPmd7Xw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,230,1763452800"; d="scan'208";a="204398219" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa010.jf.intel.com with ESMTP; 16 Jan 2026 00:55:06 -0800 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, Suraj Kandpal , Gustavo Sousa , =?UTF-8?q?Micha=C5=82=20Grzelak?= Subject: [PATCH v3 2/3] drm/i915/cx0: Clear response ready & error bit Date: Fri, 16 Jan 2026 14:24:54 +0530 Message-Id: <20260116085455.571766-3-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260116085455.571766-1-suraj.kandpal@intel.com> References: <20260116085455.571766-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Clear the response ready and error bit of PORT_P2M_MESSAGE_BUS_STATUS before writing the transaction pending bit of PORT_M2P_MSGBUS_CTL as that is a hard requirement. If not done we find that the PHY hangs since it ends up in a weird state if left idle for more than 1 hour. Bspec: 65101 Signed-off-by: Suraj Kandpal Reviewed-by: Gustavo Sousa Reviewed-by: Michał Grzelak --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c index 7288065d2461..5b6b1ce40b0d 100644 --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c @@ -222,6 +222,8 @@ static int __intel_cx0_read_once(struct intel_encoder *encoder, return -ETIMEDOUT; } + intel_clear_response_ready_flag(encoder, lane); + intel_de_write(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane), XELPDP_PORT_M2P_TRANSACTION_PENDING | XELPDP_PORT_M2P_COMMAND_READ | @@ -293,6 +295,8 @@ static int __intel_cx0_write_once(struct intel_encoder *encoder, return -ETIMEDOUT; } + intel_clear_response_ready_flag(encoder, lane); + intel_de_write(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane), XELPDP_PORT_M2P_TRANSACTION_PENDING | (committed ? XELPDP_PORT_M2P_COMMAND_WRITE_COMMITTED : -- 2.34.1