From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6E28D4A5F4 for ; Mon, 19 Jan 2026 08:04:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85CBC10E362; Mon, 19 Jan 2026 08:04:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="BDgV12G7"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 805AF10E173; Mon, 19 Jan 2026 08:04:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A2E816014E; Mon, 19 Jan 2026 08:04:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C7CAC116C6; Mon, 19 Jan 2026 08:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768809850; bh=HRBEt4RF/jLlwOJnYEYMNWDtdCxSUN5YasBH6jxxKIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BDgV12G7l5a1sp8yv1MAiOTY/L1jkmyTQZGAh3jpU9VjkGMv9/T3jgHh2lE5LuXTK Q0XiE0/v6mTCIL++UG0OUkE3zwpNkiDWjOwRxhFFIi2wh+H4hSil6YHS5SELsgqCDn WeDdVnUzfPkFP37afqzkaFH2kBs5cZ3OkLmqvQ8WC6xPHnyiZoM6tCbAr4Rpggc7r2 +twjbWsZJSrJk1zeM7aeq7DGnmBtEQc4wcipZGljnLygNxxBENIhR7XiKP9tHHgxTC bG2/CJQU8uA+pwflgnBuItu8+MXhQXRs68HQNRr/vZQQeXMAP3G3vwl+sklL/3KSsp iWYoOtPON0K+w== Date: Mon, 19 Jan 2026 10:04:04 +0200 From: Leon Romanovsky To: John Hubbard Cc: Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Alex Deucher , David Airlie , Simona Vetter , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org Subject: Re: [PATCH v2 2/4] dma-buf: Document revoke semantics Message-ID: <20260119080404.GF13201@unreal> References: <20260118-dmabuf-revoke-v2-0-a03bb27c0875@nvidia.com> <20260118-dmabuf-revoke-v2-2-a03bb27c0875@nvidia.com> <20260119072524.GD13201@unreal> <3380a80a-7574-4dbf-87cb-0735fb20cd15@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3380a80a-7574-4dbf-87cb-0735fb20cd15@nvidia.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, Jan 18, 2026 at 11:32:20PM -0800, John Hubbard wrote: > On 1/18/26 11:25 PM, Leon Romanovsky wrote: > > On Sun, Jan 18, 2026 at 01:40:11PM -0800, John Hubbard wrote: > > > On 1/18/26 4:08 AM, Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > ... > > > > +/** > > > > + * dma_buf_attachment_is_revoke - check if a DMA-buf importer implements > > > > + * revoke semantics. > > > > + * @attach: the DMA-buf attachment to check > > > > + * > > > > + * Returns true if DMA-buf importer honors revoke semantics, which is > > > > + * negotiated with the exporter, by making sure that importer implements > > > > + * .invalidate_mappings() callback and calls to dma_buf_pin() after > > > > + * DMA-buf attach. > > > > + */ > > > > +static inline bool > > > > +dma_buf_attachment_is_revoke(struct dma_buf_attachment *attach) > > > > > > Maybe a slight rename, to dma_buf_attachment_is_revocable()? > > > > I can do that. The issue is that even "dma_buf_attachment_is_revoke" > > is already too long. :) > > > > If you're really pressed for space for some reason, Mainly aesthetics. > maybe dma_buf_attach_revocable() ? > > Just trying to hang on to the "revocable" part of the name, as > I think it's an improvement. Sure > > thanks, > -- > John Hubbard > >