Re: [PATCH v3 5/6] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup

Matthew Brost
2026-01-20T20:40:27Z

On Tue, Jan 20, 2026 at 03:16:20PM -0500, Zhanjun Dong wrote:
> Manual sanitization is redundant as the driver has transitioned to using
> device-managed actions for GuC state cleanup.

or if the firmware fails to load in GT resets the device is wedged also
initiating a GuC state cleanup.

With an adjusted comment:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> drivers/gpu/drm/xe/xe_uc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index 3f63c2a7e86d..39101120d43a 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -171,7 +171,6 @@ static int vf_uc_load_hw(struct xe_uc *uc)
> return 0;
>
> err_out:
> - xe_guc_sanitize(&uc->guc);
> return err;
> }
>
> @@ -229,7 +228,6 @@ int xe_uc_load_hw(struct xe_uc *uc)
> return 0;
>
> err_out:
> - xe_guc_sanitize(&uc->guc);
> return ret;
> }
>
> --
> 2.34.1
>