Re: [PATCH v3 4/6] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED

Dong, Zhanjun
2026-01-20T22:56:46Z

On 2026-01-20 3:54 p.m., Matthew Brost wrote:
> On Tue, Jan 20, 2026 at 03:16:19PM -0500, Zhanjun Dong wrote:
>> The GuC CT state transition requires moving to the STOP state before
>> entering the DISABLED state. Updated the state machine logic to enforce
>> this sequence.
>>
>
> s/Updated the state machine logic to enforce this sequence./Update the
> driver teardown sequence to make the proper state machine transitions./
>
>> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
>
> With an adjusted commit message:
>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>
> This is also probably a fixes patch too.
Good point. Let me add it in next rev.

Zhanjun

>
> Matt
>
>> ---
>> drivers/gpu/drm/xe/xe_guc_ct.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
>> index dfbf76037b04..6a658f085e0f 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>> @@ -345,6 +345,7 @@ static void guc_action_disable_ct(void *arg)
>> {
>> struct xe_guc_ct *ct = arg;
>>
>> + xe_guc_ct_stop(ct);
>> guc_ct_change_state(ct, XE_GUC_CT_STATE_DISABLED);
>> }
>>
>> --
>> 2.34.1
>>