From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86117C4453D for ; Wed, 21 Jan 2026 13:54:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 955A910E7F5; Wed, 21 Jan 2026 13:54:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="foc77zgd"; dkim-atps=neutral Received: from lankhorst.se (lankhorst.se [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 991A710E7E8; Wed, 21 Jan 2026 13:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1769003639; bh=GP729jmpCGUY+Fn/glAufP8wPOvQXQuKRr876LaC2MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=foc77zgdnjzBlqLfpIFVXQdNwcXcJuvb5MT0wbVIXhiPb9/8PVfhLlE87fkElts4b ot7+CUUfN9oxhvnZlGHi5bu7rTOoKjcFlWbd8XHtil1qTkmBPrNYopoyTra5b6ZNlA Te4rPyM/2X2cvxhS9q+WFA64L1s1cg1UnxYeE9w0bje+oZCO4OkUbkY7c3uliP/S2P R8g6B6GWtrDdCCqGuOXlTtS9+keiL5t/sME5nta+HLm7nBuOgGm5V+uHp1eWhmOS52 GPFC+s0tRm98OVkjLuQnqzE+XC+4Dbd4U1CUY4SfeVaCLIQheB/UB5XYB/qfBUH4sp cNikfb/Ah4Oow== From: Maarten Lankhorst To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Maarten Lankhorst Subject: [i915-rt v5 19/21] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Date: Wed, 21 Jan 2026 14:53:15 +0100 Message-ID: <20260121135318.651622-20-dev@lankhorst.se> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260121135318.651622-1-dev@lankhorst.se> References: <20260121135318.651622-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" TODO: Grab uncore lock during entire vblank evasion before disabling interrupts, and check what breaks? Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/i9xx_wm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c index 39dfceb438ae4..62a988ce11ece 100644 --- a/drivers/gpu/drm/i915/display/i9xx_wm.c +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c @@ -1863,7 +1863,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); - struct intel_uncore *uncore = to_intel_uncore(display->drm); const struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc); const struct vlv_fifo_state *fifo_state = @@ -1892,7 +1891,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, * intel_pipe_update_start() has already disabled interrupts * for us, so a plain spin_lock() is sufficient here. */ - spin_lock(&uncore->lock); switch (crtc->pipe) { case PIPE_A: @@ -1951,8 +1949,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, } intel_de_read_fw(display, DSPARB(display)); - - spin_unlock(&uncore->lock); } #undef VLV_FIFO -- 2.51.0