From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F922D625C3 for ; Thu, 22 Jan 2026 01:50:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09A8A10E8B6; Thu, 22 Jan 2026 01:50:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZGdij6eN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7089410E272; Thu, 22 Jan 2026 01:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769046598; x=1800582598; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gaWyNA4LDS5RUhaxcs6NXfeixteqSl7md0zCzYHA51I=; b=ZGdij6eNkrb7X/6/hQ7NNpPH27oGDr+9SE9ZUdHAVRm+YB+VZukbTdsY se6jZ+6f+ZT0gY/3jT7vXRvpHRJYye1uU8kEPX8jx3w3w4Bn/AsXrhOuX Ii0xvZX76U1ME7KnMr/+K35bhZfoQmH/ciCQRnbfRJ+9D5DPa0SxT7im9 UPe1Ri2vQN2RkMPlXwZ90/5m18rKj50oldMM5hVww1hB5XvhNyxgQJMs4 cEgQ/Fda2LHx9QOrf6rpL2gmsvOL+kO6CETBmCtpgvuxLgXiFJW0QqTeV HkV/CAJri11t3sf/TjAuOgMVEN0qKd36QsJkGRrzG+LY55SqXLjr00YfV A==; X-CSE-ConnectionGUID: B4CxdtK/Q8u7mL6GTr7cEw== X-CSE-MsgGUID: Hh/Iy65lS2uKzg2rwRJ44w== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="73910950" X-IronPort-AV: E=Sophos;i="6.21,244,1763452800"; d="scan'208";a="73910950" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 17:49:56 -0800 X-CSE-ConnectionGUID: QEAyRyNaQRuVQKQsYIZuaQ== X-CSE-MsgGUID: PoPJe1hWT1mZUQcauzwQBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,244,1763452800"; d="scan'208";a="211616435" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 17:49:56 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v2 6/6] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec Date: Wed, 21 Jan 2026 17:49:47 -0800 Message-ID: <20260122014948.3158069-7-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122014948.3158069-1-david.e.box@linux.intel.com> References: <20260122014948.3158069-1-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Some platforms expose PMT discovery via ACPI instead of PCI BARs. Add a generic discovery source flag and carry ACPI discovery entries alongside the existing PCI resource path so PMT clients can consume either. Changes: - Add enum intel_vsec_disc_source { _PCI, _ACPI }. - Extend intel_vsec_platform_info and intel_vsec_device with source enum and ACPI discovery table pointer. - When src=3D=3DACPI, skip BAR resource setup and copy the ACPI discovery entries into the aux device. No user-visible behavior change yet; this only wires ACPI data through vsec in preparation for ACPI-enumerated PMT clients. Signed-off-by: David E. Box --- v2: - Improve comment to clarify BAR resource setup doesn't apply to ACPI discovery - Add missing #include for kmemdup() - Use array_size() for overflow protection (review comments by Ilpo J=C3=A4rvinen) drivers/platform/x86/intel/vsec.c | 16 ++++++++++++++++ include/linux/intel_vsec.h | 20 +++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 4aeb0728b435..26c6082e30b7 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -109,6 +109,7 @@ static void intel_vsec_dev_release(struct device *dev) =20 ida_free(intel_vsec_dev->ida, intel_vsec_dev->auxdev.id); =20 + kfree(intel_vsec_dev->acpi_disc); kfree(intel_vsec_dev->resource); kfree(intel_vsec_dev); } @@ -320,6 +321,10 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head * auxiliary device driver. */ for (i =3D 0, tmp =3D res; i < header->num_entries; i++, tmp++) { + /* This check doesn't apply to ACPI based discovery */ + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) + break; + tmp->start =3D base_addr + header->offset + i * (header->entry_size * si= zeof(u32)); tmp->end =3D tmp->start + (header->entry_size * sizeof(u32)) - 1; tmp->flags =3D IORESOURCE_MEM; @@ -338,6 +343,17 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head intel_vsec_dev->base_addr =3D info->base_addr; intel_vsec_dev->priv_data =3D info->priv_data; intel_vsec_dev->cap_id =3D cap_id; + intel_vsec_dev->src =3D info->src; + + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) { + size_t bytes; + + bytes =3D intel_vsec_dev->num_resources * sizeof(info->acpi_disc[0]); + + intel_vsec_dev->acpi_disc =3D kmemdup(info->acpi_disc, bytes, GFP_KERNEL= ); + if (!intel_vsec_dev->acpi_disc) + return -ENOMEM; + } =20 if (header->id =3D=3D VSEC_ID_SDSI) intel_vsec_dev->ida =3D &intel_vsec_sdsi_ida; diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 4eecb2a6bac4..1fe5665a9d02 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -33,6 +33,11 @@ struct device; struct pci_dev; struct resource; =20 +enum intel_vsec_disc_source { + INTEL_VSEC_DISC_PCI, /* PCI, default */ + INTEL_VSEC_DISC_ACPI, /* ACPI */ +}; + enum intel_vsec_id { VSEC_ID_TELEMETRY =3D 2, VSEC_ID_WATCHER =3D 3, @@ -103,6 +108,10 @@ struct vsec_feature_dependency { * @parent: parent device in the auxbus chain * @headers: list of headers to define the PMT client devices to create * @deps: array of feature dependencies + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @provider =3D=3D INTEL_VSEC_DISC_ACPI. + * @src: source of discovery table data * @priv_data: private data, usable by parent devices, currently a callback * @caps: bitmask of PMT capabilities for the given headers * @quirks: bitmask of VSEC device quirks @@ -113,6 +122,8 @@ struct intel_vsec_platform_info { struct device *parent; struct intel_vsec_header **headers; const struct vsec_feature_dependency *deps; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; void *priv_data; unsigned long caps; unsigned long quirks; @@ -124,7 +135,12 @@ struct intel_vsec_platform_info { * struct intel_vsec_device - Auxbus specific device information * @auxdev: auxbus device struct for auxbus access * @dev: struct device associated with the device - * @resource: any resources shared by the parent + * @resource: PCI discovery resources (BAR windows), one per discovery + * instance. Valid only when @src =3D=3D INTEL_VSEC_DISC_P= CI + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @src =3D=3D INTEL_VSEC_DISC_ACPI. + * @src: source of discovery table data * @ida: id reference * @num_resources: number of resources * @id: xarray id @@ -138,6 +154,8 @@ struct intel_vsec_device { struct auxiliary_device auxdev; struct device *dev; struct resource *resource; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; struct ida *ida; int num_resources; int id; /* xa */ --=20 2.43.0