Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: leonro@nvidia.com, francois.dugast@intel.com,
	thomas.hellstrom@linux.intel.com,
	himal.prasad.ghimiray@intel.com, jgg@ziepe.ca
Subject: [RFC PATCH v3 05/11] drm/pagemap: Reduce number of IOVA link calls
Date: Tue, 27 Jan 2026 16:48:35 -0800	[thread overview]
Message-ID: <20260128004841.2436896-6-matthew.brost@intel.com> (raw)
In-Reply-To: <20260128004841.2436896-1-matthew.brost@intel.com>

Each IOVA link call results in a page walk, which is relatively
expensive. Reduce the number of IOVA link calls by collapsing
contiguous physical pages into a single IOVA link operation.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/drm_pagemap.c | 49 ++++++++++++++++++++++++++---------
 1 file changed, 37 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/drm_pagemap.c b/drivers/gpu/drm/drm_pagemap.c
index b928c89f4bd1..a167064ce41a 100644
--- a/drivers/gpu/drm/drm_pagemap.c
+++ b/drivers/gpu/drm/drm_pagemap.c
@@ -305,7 +305,8 @@ drm_pagemap_migrate_map_system_pages(struct device *dev,
 				     struct dma_iova_state *state)
 {
 	struct page *dummy_page = NULL;
-	unsigned long i, psize;
+	unsigned long i, j, psize;
+	phys_addr_t phys = -1;
 	bool try_alloc = false;
 
 	for (i = 0; i < npages;) {
@@ -339,26 +340,50 @@ drm_pagemap_migrate_map_system_pages(struct device *dev,
 
 		if (dma_use_iova(state)) {
 			bool found_dummy = page && !dummy_page;
+			bool phys_match;
 			int err;
 
-			if (found_dummy) {
-				unsigned long j;
+			if (found_dummy && i) {
+				err = dma_iova_link(dev, state,
+						    page_to_phys(page),
+						    0, i * PAGE_SIZE,
+						    dir, 0);
+				if (err)
+					return err;
+			}
+
+			if (phys == -1) {
+				phys = page_to_phys(page);
+				j = i;
+				phys_match = true;
+			} else {
+				phys_match = phys + (i - j) * PAGE_SIZE ==
+					page_to_phys(page);
+			}
 
-				for (j = 0; j < i; ++j) {
+			if (psize != PAGE_SIZE || !phys_match ||
+			    (i + 1) == npages) {
+				err = dma_iova_link(dev, state, phys,
+						    j * PAGE_SIZE,
+						    psize * ((i - j) +
+						    phys_match),
+						    dir, 0);
+				if (err)
+					return err;
+
+				if (!phys_match && (i + 1) == npages) {
 					err = dma_iova_link(dev, state,
 							    page_to_phys(page),
-							    j * PAGE_SIZE,
-							    PAGE_SIZE, dir, 0);
+							    i * PAGE_SIZE,
+							    psize,
+							    dir, 0);
 					if (err)
 						return err;
 				}
-			}
 
-			err = dma_iova_link(dev, state, page_to_phys(page),
-					    i * PAGE_SIZE, psize,
-					    dir, 0);
-			if (err)
-				return err;
+				phys = page_to_phys(page);
+				j = i;
+			}
 
 			if (page != dummy_page)
 				dma_addr = state->addr + i * PAGE_SIZE;
-- 
2.34.1


  parent reply	other threads:[~2026-01-28  0:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  0:48 [RFC PATCH v3 00/11] Use new dma-map IOVA alloc, link, and sync API in GPU SVM and DRM pagemap Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 01/11] drm/pagemap: Add helper to access zone_device_data Matthew Brost
2026-01-28 13:53   ` Leon Romanovsky
2026-01-28  0:48 ` [RFC PATCH v3 02/11] drm/gpusvm: Use dma-map IOVA alloc, link, and sync API in GPU SVM Matthew Brost
2026-01-28 14:04   ` Leon Romanovsky
2026-01-28  0:48 ` [RFC PATCH v3 03/11] drm/pagemap: Split drm_pagemap_migrate_map_pages into device / system Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 04/11] drm/pagemap: Use dma-map IOVA alloc, link, and sync API for DRM pagemap Matthew Brost
2026-01-28 14:28   ` Leon Romanovsky
2026-01-28 17:46     ` Matthew Brost
     [not found]       ` <20260128175531.GR1641016@ziepe.ca>
2026-01-28 19:29         ` Matthew Brost
2026-01-28 19:45           ` Leon Romanovsky
2026-01-28 21:04             ` Matthew Brost
2026-01-29 10:14               ` Leon Romanovsky
2026-01-29 18:22                 ` Matthew Brost
2026-01-28  0:48 ` Matthew Brost [this message]
2026-01-28  0:48 ` [RFC PATCH v3 06/11] drm/pagemap: Add IOVA interface to " Matthew Brost
     [not found]   ` <20260128151458.GJ1641016@ziepe.ca>
2026-01-28 18:42     ` Matthew Brost
2026-01-28 19:41       ` Matthew Brost
     [not found]       ` <20260128193509.GU1641016@ziepe.ca>
2026-01-28 20:24         ` Matthew Brost
2026-01-29 18:57           ` Jason Gunthorpe
2026-01-29 19:28             ` Matthew Brost
2026-01-29 19:32               ` Jason Gunthorpe
2026-01-28  0:48 ` [RFC PATCH v3 07/11] drm/xe: Stub out DRM pagemap IOVA alloc implementation Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 08/11] drm/pagemap: Use device-to-device IOVA alloc, link, and sync API for DRM pagemap Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 09/11] drm/xe: Drop BO dma-resv lock during SVM migrate-to-device Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 10/11] drm/xe: Implement DRM pagemap IOVA vfuncs Matthew Brost
2026-01-28  0:48 ` [RFC PATCH v3 11/11] drm/gpusvm: Use device-to-device IOVA alloc, link, and sync API in GPU SVM Matthew Brost
2026-01-28  0:59 ` ✗ CI.checkpatch: warning for Use new dma-map IOVA alloc, link, and sync API in GPU SVM and DRM pagemap (rev3) Patchwork
2026-01-28  1:01 ` ✓ CI.KUnit: success " Patchwork
2026-01-28  1:42 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128004841.2436896-6-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francois.dugast@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jgg@ziepe.ca \
    --cc=leonro@nvidia.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox