From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DA8AE6BF0E for ; Fri, 30 Jan 2026 13:37:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F165110E9E1; Fri, 30 Jan 2026 13:36:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kcZnDYYP"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id E58D310E9E1 for ; Fri, 30 Jan 2026 13:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769780218; x=1801316218; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uiKi1kLCK8GQbmjF6MiSfNXxUnT0cATJ7oaikOcErww=; b=kcZnDYYPOT9/Dqq/rU3IfOU2xBnVzeqM4iQ7fOCGeHCYst89UlWQ/LGL mM6Bl+uwXJkIlsiZRKPN1Gu4rxAr3RzRxst3L5jvbT8ExOPCN0QMNBeai sQcZQgL/cT3qMIGitQWRg4DHbDT0RqYEMyQa+rrfROMa3bnPMKnsqMRao SZVg4BD9Gkb6jJsOc6zC781NyQRjEBqsEhLLpn0Q9jgmKkLfy1IlHUfS1 VIRAYaLSrapUmLuxGZ0R3SWr7iE5BERC4L9rC0N34gov173pBm4rHKkzR aD5kfeZ0/FdQxc1nDvqZrw0cXDWUIG7w3XiWbiTuI97Yw+XiM3dvMUSkl g==; X-CSE-ConnectionGUID: sZkFDN4EQvSEzY5rLORFdw== X-CSE-MsgGUID: egc4cMsHRxqw9FPgofaplQ== X-IronPort-AV: E=McAfee;i="6800,10657,11686"; a="71194389" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="71194389" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 05:36:58 -0800 X-CSE-ConnectionGUID: wfv7t4ObSyObglsnxgkCSw== X-CSE-MsgGUID: VTj+Du67T8K9gEENMdyKHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="207983238" Received: from mjruhl-desk.amr.corp.intel.com (HELO mjruhl-desk.intel.com) ([10.124.220.170]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 05:36:56 -0800 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com Cc: "Michael J. Ruhl" Subject: [PATCH v2 2/5] drm/xe/vsec: Use correct pm state get Date: Fri, 30 Jan 2026 08:36:42 -0500 Message-ID: <20260130133639.765378-9-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260130133639.765378-7-michael.j.ruhl@intel.com> References: <20260130133639.765378-7-michael.j.ruhl@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Crashlog needs to be collected at all times. The current pm check assumes telemetry only. Update read path to enable device for crashlog instances. Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/xe/xe_vsec.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index 4ebb4dbe1c9b..44607f1eaa88 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -145,6 +145,7 @@ int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_off { struct xe_device *xe = pdev_to_xe_device(pdev); void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET; + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); u32 mem_region; u32 offset; int ret; @@ -160,9 +161,18 @@ int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_off if (!xe->soc_remapper.set_telem_region) return -ENODEV; - /* indicate that we are not at an appropriate power level */ - if (!xe_pm_runtime_get_if_active(xe)) - return -ENODATA; + /* make sure that we are not at an inappropriate power level */ + switch (cap_type) { + case CRASHLOG: + xe_pm_runtime_get(xe); + break; + case TELEMETRY: + if (!xe_pm_runtime_get_if_active(xe)) + return -ENODATA; + break; + case WATCHER: + return -EINVAL; + } /* set SoC re-mapper index register based on GUID memory region */ xe->soc_remapper.set_telem_region(xe, mem_region); -- 2.52.0