Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Piórkowski, Piotr" <piotr.piorkowski@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: "Piotr Piórkowski" <piotr.piorkowski@intel.com>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Michal Wajdeczko" <michal.wajdeczko@intel.com>
Subject: [PATCH v1] drm/xe/vf: Avoid reading media version when media GT is disabled
Date: Fri, 30 Jan 2026 16:55:22 +0100	[thread overview]
Message-ID: <20260130155522.2738547-1-piotr.piorkowski@intel.com> (raw)

From: Piotr Piórkowski <piotr.piorkowski@intel.com>

When the media GT is not allowed, a VF must not attempt to read
the media version from the GuC. The GuC may not be loaded, and
any attempt to communicate with it would result in a timeout
and a VF probe failure:

(...)
[ 1912.406046] xe 0000:01:00.1: [drm] *ERROR* Tile0: GT1: GuC mmio request 0x5507: no reply 0x5507
[ 1912.407277] xe 0000:01:00.1: [drm] *ERROR* Tile0: GT1: [GUC COMMUNICATION] MMIO send failed (-ETIMEDOUT)
[ 1912.408689] xe 0000:01:00.1: [drm] *ERROR* VF: Tile0: GT1: Failed to reset GuC state (-ETIMEDOUT)
[ 1912.413986] xe 0000:01:00.1: probe with driver xe failed with error -110

Let's skip reading the media version for VFs when the media GT is not
allowed.

Fixes: 7abd69278bb5 ("drm/xe/configfs: Add attribute to disable GT types")
Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index b5e8935fff1d..6ac1baabab4e 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -644,6 +644,10 @@ static int handle_gmdid(struct xe_device *xe,
 			ver / 100, ver % 100);
 	}
 
+	/* Don't try read media ver if media GT is not allowed */
+	if (!xe_configfs_media_gt_allowed(to_pci_dev(xe->drm.dev)))
+		return 0;
+
 	ret = read_gmdid(xe, GMDID_MEDIA, &ver, media_revid);
 	if (ret)
 		return ret;
-- 
2.34.1


             reply	other threads:[~2026-01-30 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30 15:55 Piórkowski, Piotr [this message]
2026-01-30 16:02 ` ✓ CI.KUnit: success for drm/xe/vf: Avoid reading media version when media GT is disabled Patchwork
2026-01-30 16:35 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-30 18:08 ` [PATCH v1] " Lin, Shuicheng
2026-01-30 18:20   ` Lin, Shuicheng
2026-02-02  8:43     ` Piotr Piórkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130155522.2738547-1-piotr.piorkowski@intel.com \
    --to=piotr.piorkowski@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox