Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, imre.deak@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH v2] drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare
Date: Wed,  4 Feb 2026 08:02:47 +0530	[thread overview]
Message-ID: <20260204023247.1560196-1-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260203024141.1549517-1-suraj.kandpal@intel.com>

TBT PHY is enablement/disablement is handled by its own TBT module.
We do not play a big part in it's state management, that being take care
by it's own TBT modeule.
The PHY/PLL TypeC mode (TBT, DP-alt) can change after the PLL state was
computed for a modeset, so the state verification after the modeset
sequence would indicate a mismatch in case the mode changed from DP-alt
to TBT, or from TBT to DP-alt mode. To avoid such a mismatch error the
verification is skipped if the mode for either the read-out or the
computed state is TBT (where that TBT PLL state doesn't reflect anyway
the PLL's actual HW state).
Simply return true when we are in tbt mode.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
V1 -> V2:
- Reframe commit messgae with give the full explanation as to why we
skip verification (Imre)

 drivers/gpu/drm/i915/display/intel_lt_phy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy.c b/drivers/gpu/drm/i915/display/intel_lt_phy.c
index 04f63bdd0b87..27ad8407606b 100644
--- a/drivers/gpu/drm/i915/display/intel_lt_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_lt_phy.c
@@ -2158,6 +2158,9 @@ bool
 intel_lt_phy_pll_compare_hw_state(const struct intel_lt_phy_pll_state *a,
 				  const struct intel_lt_phy_pll_state *b)
 {
+	if (a->tbt_mode || b->tbt_mode)
+		return true;
+
 	/*
 	 * With LT PHY values other than VDR0_CONFIG and VDR2_CONFIG are
 	 * unreliable. They cannot always be read back since internally
-- 
2.34.1


  parent reply	other threads:[~2026-02-04  2:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  2:41 [PATCH] drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare Suraj Kandpal
2026-02-03  8:05 ` ✓ CI.KUnit: success for " Patchwork
2026-02-03  8:25 ` [PATCH] " Imre Deak
2026-02-03  8:40   ` Kandpal, Suraj
2026-02-03 16:10     ` Imre Deak
2026-02-04  2:23       ` Kandpal, Suraj
2026-02-03  8:43 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-03 21:29 ` ✓ Xe.CI.FULL: " Patchwork
2026-02-04  2:32 ` Suraj Kandpal [this message]
2026-02-04 11:24   ` [PATCH v2] " Imre Deak
2026-02-04  2:49 ` ✓ CI.KUnit: success for drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare (rev2) Patchwork
2026-02-04  3:25 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04 17:03 ` ✓ CI.KUnit: success for drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare (rev3) Patchwork
2026-02-04 17:42 ` ✗ Xe.CI.FULL: failure for drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare (rev2) Patchwork
2026-02-04 17:46 ` ✗ Xe.CI.BAT: failure for drm/i915/ltphy: Return true for TBT scenario during lt_phy_state compare (rev3) Patchwork
2026-02-04 20:30 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-05  3:42 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204023247.1560196-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox