From: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
rodrigo.vivi@intel.com
Cc: andrealmeid@igalia.com, christian.koenig@amd.com,
airlied@gmail.com, simona.vetter@ffwll.ch, mripard@kernel.org,
anshuman.gupta@intel.com, badal.nilawar@intel.com,
riana.tauro@intel.com, karthik.poosa@intel.com,
sk.anirban@intel.com, raag.jadav@intel.com,
Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Subject: [PATCH 3/4] drm/xe: Add handler for critical errors which require cold-reset
Date: Wed, 11 Feb 2026 17:29:50 +0530 [thread overview]
Message-ID: <20260211115946.2014051-9-mallesh.koujalagi@intel.com> (raw)
In-Reply-To: <20260211115946.2014051-6-mallesh.koujalagi@intel.com>
This handler is designed to be called when critical errors are detected
that affect device-level state persisting across warm resets. The cold
reset recovery method signals to userspace that only a complete device
power cycle can restore normal operation.
Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
---
drivers/gpu/drm/xe/xe_hw_error.c | 28 ++++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_hw_error.h | 1 +
2 files changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_hw_error.c b/drivers/gpu/drm/xe/xe_hw_error.c
index 8c65291f36fc..d7825d6b9703 100644
--- a/drivers/gpu/drm/xe/xe_hw_error.c
+++ b/drivers/gpu/drm/xe/xe_hw_error.c
@@ -5,6 +5,8 @@
#include <linux/fault-inject.h>
+#include <drm/drm_drv.h>
+
#include "regs/xe_gsc_regs.h"
#include "regs/xe_hw_error_regs.h"
#include "regs/xe_irq_regs.h"
@@ -162,6 +164,32 @@ static void process_hw_errors(struct xe_device *xe)
}
}
+/**
+ * xe_critical_error_handler - Handler for critical errors
+ * @xe: device instance
+ *
+ * Handles critical errors that affect the device and cannot
+ * be recovered through driver reload, PCIe reset, etc.
+ *
+ * Marks the device as wedged with DRM_WEDGE_RECOVERY_COLD_RESET method
+ * and notifies userspace that a complete device power cycle is required.
+ */
+void xe_critical_error_handler(struct xe_device *xe)
+{
+ drm_err(&xe->drm, "CRITICAL: error detected\n");
+ drm_err(&xe->drm, "Recovery: Device cold reset required\n");
+
+ /* Set cold reset recovery method */
+ xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_COLD_RESET);
+
+ if (xe_device_wedged(xe)) {
+ drm_dev_wedged_event(&xe->drm, xe->wedged.method, NULL);
+ } else {
+ /* Declare device wedged - will trigger uevent with cold reset method */
+ xe_device_declare_wedged(xe);
+ }
+}
+
/**
* xe_hw_error_init - Initialize hw errors
* @xe: xe device instance
diff --git a/drivers/gpu/drm/xe/xe_hw_error.h b/drivers/gpu/drm/xe/xe_hw_error.h
index d86e28c5180c..f824e22655a0 100644
--- a/drivers/gpu/drm/xe/xe_hw_error.h
+++ b/drivers/gpu/drm/xe/xe_hw_error.h
@@ -11,5 +11,6 @@ struct xe_tile;
struct xe_device;
void xe_hw_error_irq_handler(struct xe_tile *tile, const u32 master_ctl);
+void xe_critical_error_handler(struct xe_device *xe);
void xe_hw_error_init(struct xe_device *xe);
#endif
--
2.34.1
next prev parent reply other threads:[~2026-02-11 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 11:59 [RFC PATCH 0/4] Add cold reset recovery method for critical errors Mallesh Koujalagi
2026-02-11 11:59 ` [PATCH 1/4] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET for critical error Mallesh Koujalagi
2026-02-11 11:59 ` [PATCH 2/4] drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-02-11 13:29 ` Jani Nikula
2026-02-12 7:54 ` Mallesh, Koujalagi
2026-02-11 11:59 ` Mallesh Koujalagi [this message]
2026-02-11 11:59 ` [PATCH 4/4] drm/xe/debugfs: Add interface to trigger critical error handler Mallesh Koujalagi
2026-02-11 12:27 ` [RFC PATCH 0/4] Add cold reset recovery method for critical errors Christian König
2026-02-13 10:39 ` Mallesh, Koujalagi
2026-02-11 15:02 ` ✓ CI.KUnit: success for " Patchwork
2026-02-11 15:23 ` ✗ CI.checksparse: warning " Patchwork
2026-02-11 16:16 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-12 22:30 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211115946.2014051-9-mallesh.koujalagi@intel.com \
--to=mallesh.koujalagi@intel.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=mripard@kernel.org \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox