From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com,
Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 3/8] drm/i915/backlight: Take luminance_set into account for VESA backlight
Date: Fri, 13 Feb 2026 14:46:48 +0530 [thread overview]
Message-ID: <20260213091653.2250887-4-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260213091653.2250887-1-suraj.kandpal@intel.com>
When deciding what functions to enable to help control backlight we
used to only check aux_enable. Now with PANEL_LUMINANCE_OVERRIDE in
picture we need to take care that we do not enable PWM function if
luminance_set is set.
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15671
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 0237cad11299..4a67068f4098 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -490,7 +490,8 @@ intel_dp_aux_vesa_enable_backlight(const struct intel_crtc_state *crtc_state,
struct intel_panel *panel = &connector->panel;
struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
- if (!panel->backlight.edp.vesa.info.aux_enable) {
+ if (!(panel->backlight.edp.vesa.info.aux_enable ||
+ panel->backlight.edp.vesa.info.luminance_set)) {
u32 pwm_level;
if (!panel->backlight.edp.vesa.info.aux_set)
--
2.34.1
next prev parent reply other threads:[~2026-02-13 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 9:16 [PATCH 0/8] Fixes and updates when using AUX backlight using Luminance Suraj Kandpal
2026-02-13 9:16 ` [PATCH 1/8] drm/i915/backlight: Avoid 0 brightness for VESA AUX backlight Suraj Kandpal
2026-02-18 8:35 ` Murthy, Arun R
2026-02-13 9:16 ` [PATCH 2/8] drm/i915/backlight: Use intel_panel variable instead of intel_connector Suraj Kandpal
2026-02-13 9:16 ` Suraj Kandpal [this message]
2026-02-13 9:16 ` [PATCH 4/8] drm/i915/backlight: Check luminance_set when disabling PWM via AUX VESA backlight Suraj Kandpal
2026-02-13 9:16 ` [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Suraj Kandpal
2026-02-13 9:16 ` [PATCH 6/8] drm/i915/backlight: Update debug log during backlight setup Suraj Kandpal
2026-02-13 9:16 ` [PATCH 7/8] drm/i915/backlight: Provide clear description on how backlight level is controlled Suraj Kandpal
2026-02-13 9:16 ` [PATCH 8/8] drm/i915/backlight: Avoid 0 brightness for INTEL AUX HDR backlight Suraj Kandpal
2026-02-13 9:45 ` ✗ CI.checkpatch: warning for Fixes and updates when using AUX backlight using Luminance Patchwork
2026-02-13 9:46 ` ✓ CI.KUnit: success " Patchwork
2026-02-13 10:22 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-14 6:28 ` ✗ Xe.CI.FULL: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2026-02-20 5:02 [PATCH 0/8] " Suraj Kandpal
2026-02-20 5:02 ` [PATCH 3/8] drm/i915/backlight: Take luminance_set into account for VESA backlight Suraj Kandpal
2026-02-24 2:54 ` Murthy, Arun R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213091653.2250887-4-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox