From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D128EF99E3 for ; Fri, 13 Feb 2026 22:34:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3955F10E85F; Fri, 13 Feb 2026 22:34:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XMg2/JTU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id A939110E859; Fri, 13 Feb 2026 22:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771022054; x=1802558054; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uZ07heVApOLl/yI9uyK4cy2X1pAKnsq0+/YkCxI6E0g=; b=XMg2/JTUylvHJu08oa1hNm7eqPGJGxdvhWIX1qH6yaZB1NmWZVT470R7 1MLfvaU19QcjIrHjDcTaEEQhttS/rrlBrbR3nU6r4ch9SqOw/CCCRDDXn BnOLF0oFSVo2w+snvCiK7WgcWZmc1iE28DU6ZbyFDT3WX0h7WfLzrLTg/ 5JcpSN87fc13+NWrUDEIcKDBOuNH0CJtxh4FZWL2kWci26UrGUUNmk+iT nPNZV2BolFc9AwdnwP+X4oCElrEZ7h9ztdEF3s6p89KcjBBLDfcvbL8Rp x0eD+88e9+eCJ58sADU8grwfHcvNta6bSEWCRN0uW89OWW39BlWd0GZn2 w==; X-CSE-ConnectionGUID: iGJVLuSLSQesA+UiA+wqzQ== X-CSE-MsgGUID: T+U134vTTyi02cwwGCzJEQ== X-IronPort-AV: E=McAfee;i="6800,10657,11700"; a="94844919" X-IronPort-AV: E=Sophos;i="6.21,289,1763452800"; d="scan'208";a="94844919" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2026 14:34:14 -0800 X-CSE-ConnectionGUID: Se3HThLfTBWpbDxIbbfwgA== X-CSE-MsgGUID: pMZ7zMlRS9CCt2SGROAt6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,289,1763452800"; d="scan'208";a="250698294" Received: from dut4086lnl.fm.intel.com ([10.105.11.7]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2026 14:34:13 -0800 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, shuicheng.lin@intel.com, dri-devel@lists.freedesktop.org, Michal.Wajdeczko@intel.com, michal.mrozek@intel.com, raag.jadav@intel.com, ivan.briano@intel.com, matthew.auld@intel.com, dafna.hirschfeld@intel.com Subject: [PATCH v34 1/6] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Date: Fri, 13 Feb 2026 22:34:12 +0000 Message-ID: <20260213223410.99613-9-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260213223410.99613-8-jonathan.cavitt@intel.com> References: <20260213223410.99613-8-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in xe_pagefault_service after the VMA lookup. v2: - Apply max line length (Matthew) Fixes: fb544b844508 ("drm/xe: Implement xe_pagefault_queue_work") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost Cc: Shuicheng Lin Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index 72f589fd2b64..0281b5b6d4ab 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -187,6 +187,12 @@ static int xe_pagefault_service(struct xe_pagefault *pf) goto unlock_vm; } + if (xe_vma_read_only(vma) && + pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) { + err = -EPERM; + goto unlock_vm; + } + atomic = xe_pagefault_access_is_atomic(pf->consumer.access_type); if (xe_vma_is_cpu_addr_mirror(vma)) -- 2.43.0