From: Raag Jadav <raag.jadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.brost@intel.com, rodrigo.vivi@intel.com,
riana.tauro@intel.com, michal.wajdeczko@intel.com,
matthew.d.roper@intel.com, umesh.nerlige.ramappa@intel.com,
mallesh.koujalagi@intel.com, Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1 2/3] drm/xe/hw_error: Reuse CSC worker for generic error handling
Date: Tue, 17 Feb 2026 17:16:32 +0530 [thread overview]
Message-ID: <20260217114656.2546878-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20260217114656.2546878-1-raag.jadav@intel.com>
We have upcoming usecases which require defering work during error
handling. Since we already have CSC worker in place, prepare it to
be reused generically.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_hw_error.c | 10 +++++-----
drivers/gpu/drm/xe/xe_tile_types.h | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_error.c b/drivers/gpu/drm/xe/xe_hw_error.c
index eb557266d083..b704eab7d3bd 100644
--- a/drivers/gpu/drm/xe/xe_hw_error.c
+++ b/drivers/gpu/drm/xe/xe_hw_error.c
@@ -51,9 +51,9 @@ static bool fault_inject_csc_hw_error(void)
return IS_ENABLED(CONFIG_DEBUG_FS) && should_fail(&inject_csc_hw_error, 1);
}
-static void csc_hw_error_work(struct work_struct *work)
+static void hw_error_work(struct work_struct *work)
{
- struct xe_tile *tile = container_of(work, typeof(*tile), csc_hw_error_work);
+ struct xe_tile *tile = container_of(work, typeof(*tile), hw_error_work);
struct xe_device *xe = tile_to_xe(tile);
int ret;
@@ -90,7 +90,7 @@ static void csc_hw_error_handler(struct xe_tile *tile, const enum hardware_error
hw_err_str, hec_uncorrected_fw_errors[err_bit],
err_bit);
- schedule_work(&tile->csc_hw_error_work);
+ schedule_work(&tile->hw_error_work);
}
}
@@ -139,7 +139,7 @@ void xe_hw_error_irq_handler(struct xe_tile *tile, const u32 master_ctl)
enum hardware_error hw_err;
if (fault_inject_csc_hw_error())
- schedule_work(&tile->csc_hw_error_work);
+ schedule_work(&tile->hw_error_work);
for (hw_err = 0; hw_err < HARDWARE_ERROR_MAX; hw_err++)
if (master_ctl & ERROR_IRQ(hw_err))
@@ -193,7 +193,7 @@ void xe_hw_error_init(struct xe_device *xe)
if (!IS_DGFX(xe) || IS_SRIOV_VF(xe))
return;
- INIT_WORK(&tile->csc_hw_error_work, csc_hw_error_work);
+ INIT_WORK(&tile->hw_error_work, hw_error_work);
if (xe->info.platform == XE_CRESCENTISLAND)
xe_hw_error_irq_route(xe);
diff --git a/drivers/gpu/drm/xe/xe_tile_types.h b/drivers/gpu/drm/xe/xe_tile_types.h
index 33932fd547d7..f214e893f39e 100644
--- a/drivers/gpu/drm/xe/xe_tile_types.h
+++ b/drivers/gpu/drm/xe/xe_tile_types.h
@@ -116,8 +116,8 @@ struct xe_tile {
/** @memirq: Memory Based Interrupts. */
struct xe_memirq memirq;
- /** @csc_hw_error_work: worker to report CSC HW errors */
- struct work_struct csc_hw_error_work;
+ /** @hw_error_work: worker to handle HW errors */
+ struct work_struct hw_error_work;
/** @pcode: tile's PCODE */
struct {
--
2.43.0
next prev parent reply other threads:[~2026-02-17 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 11:46 [PATCH v1 0/3] Hardware Error handling for Crescent Island Raag Jadav
2026-02-17 11:46 ` [PATCH v1 1/3] drm/xe/cri: Setup hardware error routing Raag Jadav
2026-02-17 21:47 ` Matt Roper
2026-02-19 8:36 ` Raag Jadav
2026-03-26 12:49 ` Mallesh, Koujalagi
2026-04-01 18:21 ` Raag Jadav
2026-02-17 11:46 ` Raag Jadav [this message]
2026-02-17 11:46 ` [PATCH v1 3/3] drm/xe/cri: Wedge the device on hardware error Raag Jadav
2026-02-17 22:10 ` Matt Roper
2026-02-17 12:42 ` ✓ CI.KUnit: success for Hardware Error handling for Crescent Island Patchwork
2026-02-17 13:52 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-17 16:14 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217114656.2546878-3-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox